From: Jan Kara <jack@suse.cz>
To: Stefan Haberland <sth@linux.ibm.com>
Cc: Jan Kara <jack@suse.cz>, Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-s390@vger.kernel.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
Jan Hoeppner <hoeppner@linux.ibm.com>
Subject: Re: [PATCH 14/29] s390/dasd: Convert to bdev_open_by_path()
Date: Mon, 2 Oct 2023 13:24:47 +0200 [thread overview]
Message-ID: <20231002112447.aecbad2w6lh4p3fp@quack3> (raw)
In-Reply-To: <51e1e42a-2ed8-a664-f26f-bc5bc1762884@linux.ibm.com>
On Wed 27-09-23 23:43:44, Stefan Haberland wrote:
> Am 23.08.23 um 12:48 schrieb Jan Kara:
> > Convert dasd to use bdev_open_by_path() and pass the handle around.
> >
> > CC: linux-s390@vger.kernel.org
> > CC: Christian Borntraeger <borntraeger@linux.ibm.com>
> > CC: Sven Schnelle <svens@linux.ibm.com>
> > Acked-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
>
> The DASD part does not compile. please see below.
>
> Beside of this the patch looks OK to me.
>
> with the error fixed:
> Acked-by: Stefan Haberland <sth@linux.ibm.com>
Thanks for noticing. I can see Christian has already fixed up the problem
in his tree. I guess he'll pick up your ack once he returns from vacation.
Honza
>
> > drivers/s390/block/dasd.c | 12 +++++----
> > drivers/s390/block/dasd_genhd.c | 45 ++++++++++++++++-----------------
> > drivers/s390/block/dasd_int.h | 2 +-
> > drivers/s390/block/dasd_ioctl.c | 2 +-
> > 4 files changed, 31 insertions(+), 30 deletions(-)
> >
> > diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
> > index 215597f73be4..16a2d631a169 100644
> > --- a/drivers/s390/block/dasd.c
> > +++ b/drivers/s390/block/dasd.c
> > @@ -412,7 +412,8 @@ dasd_state_ready_to_online(struct dasd_device * device)
> > KOBJ_CHANGE);
> > return 0;
> > }
> > - disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE);
> > + disk_uevent(device->block->bdev_handle->bdev->bd_disk,
> > + KOBJ_CHANGE);
> > }
> > return 0;
> > }
> > @@ -432,7 +433,8 @@ static int dasd_state_online_to_ready(struct dasd_device *device)
> > device->state = DASD_STATE_READY;
> > if (device->block && !(device->features & DASD_FEATURE_USERAW))
> > - disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE);
> > + disk_uevent(device->block->bdev_handle->bdev->bd_disk,
> > + KOBJ_CHANGE);
> > return 0;
> > }
> > @@ -3590,7 +3592,7 @@ int dasd_generic_set_offline(struct ccw_device *cdev)
> > * in the other openers.
> > */
> > if (device->block) {
> > - max_count = device->block->bdev ? 0 : -1;
> > + max_count = device->block->bdev_handle ? 0 : -1;
> > open_count = atomic_read(&device->block->open_count);
> > if (open_count > max_count) {
> > if (open_count > 0)
> > @@ -3636,8 +3638,8 @@ int dasd_generic_set_offline(struct ccw_device *cdev)
> > * so sync bdev first and then wait for our queues to become
> > * empty
> > */
> > - if (device->block)
> > - bdev_mark_dead(device->block->bdev, false);
> > + if (device->block && device->block->bdev_handle) {
>
> the brace is not needed here and there is no matching right brace.
>
> > + bdev_mark_dead(device->block->bdev_handle->bdev, false);
> > dasd_schedule_device_bh(device);
> > rc = wait_event_interruptible(shutdown_waitq,
> > _wait_for_empty_queues(device));
> >
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-10-02 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:48 [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle Jan Kara
2023-08-23 10:48 ` [PATCH 14/29] s390/dasd: Convert to bdev_open_by_path() Jan Kara
2023-08-25 12:14 ` Christian Brauner
2023-09-27 21:43 ` Stefan Haberland
2023-10-02 11:24 ` Jan Kara [this message]
2023-08-25 13:32 ` [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle Christian Brauner
2023-08-28 17:07 ` Jan Kara
2023-08-29 11:02 ` Christian Brauner
2023-09-27 9:34 ` [PATCH v4 " Jan Kara
2023-09-27 9:34 ` [PATCH 14/29] s390/dasd: Convert to bdev_open_by_path() Jan Kara
2023-09-27 14:19 ` [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle Jens Axboe
2023-09-27 16:21 ` Christian Brauner
2023-10-02 7:57 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2023-08-11 11:04 [PATCH v2 " Jan Kara
2023-08-11 11:04 ` [PATCH 14/29] s390/dasd: Convert to bdev_open_by_path() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002112447.aecbad2w6lh4p3fp@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=borntraeger@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sth@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox