From: Nathan Chancellor <nathan@kernel.org>
To: akpm@linux-foundation.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, patches@lists.linux.dev,
Nathan Chancellor <nathan@kernel.org>,
sth@linux.ibm.com, hoeppner@linux.ibm.com
Subject: [PATCH 1/2] s390/dasd: Remove dasd_stats_generic_show()
Date: Thu, 30 Nov 2023 17:22:32 -0700 [thread overview]
Message-ID: <20231130-s390-missing-prototypes-v1-1-799d3cf07fb7@kernel.org> (raw)
In-Reply-To: <20231130-s390-missing-prototypes-v1-0-799d3cf07fb7@kernel.org>
With CONFIG_DASD_PROFILE=n, there is a warning that
dasd_stats_generic_show() is missing a prototype:
drivers/s390/block/dasd.c:1109:5: warning: no previous prototype for 'dasd_stats_generic_show' [-Wmissing-prototypes]
1109 | int dasd_stats_generic_show(struct seq_file *m, void *v)
| ^~~~~~~~~~~~~~~~~~~~~~~
This function has been unused since its introduction in
commit 4fa52aa7a82f ("[S390] dasd: add enhanced DASD statistics
interface"), remove it to clear up the warning.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Cc: sth@linux.ibm.com
Cc: hoeppner@linux.ibm.com
---
drivers/s390/block/dasd.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 833cfab7d877..7327e81352e9 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -1106,12 +1106,6 @@ static void dasd_statistics_removeroot(void)
return;
}
-int dasd_stats_generic_show(struct seq_file *m, void *v)
-{
- seq_puts(m, "Statistics are not activated in this kernel\n");
- return 0;
-}
-
static void dasd_profile_init(struct dasd_profile *profile,
struct dentry *base_dentry)
{
--
2.43.0
next prev parent reply other threads:[~2023-12-01 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 0:22 [PATCH 0/2] s390: A couple of fixes for -Wmissing-prototypes Nathan Chancellor
2023-12-01 0:22 ` Nathan Chancellor [this message]
2023-12-04 7:41 ` [PATCH 1/2] s390/dasd: Remove dasd_stats_generic_show() Alexander Gordeev
2023-12-04 13:13 ` Stefan Haberland
2023-12-01 0:22 ` [PATCH 2/2] s390/traps: Only define is_valid_bugaddr() under CONFIG_GENERIC_BUG Nathan Chancellor
2023-12-04 9:06 ` Alexander Gordeev
2023-12-04 16:38 ` Nathan Chancellor
2023-12-05 12:59 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130-s390-missing-prototypes-v1-1-799d3cf07fb7@kernel.org \
--to=nathan@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=sth@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox