From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <wintera@linux.ibm.com>
Cc: <alibuda@linux.alibaba.com>, <davem@davemloft.net>,
<edumazet@google.com>, <gbayer@linux.ibm.com>,
<guwen@linux.alibaba.com>, <jaka@linux.ibm.com>,
<kuba@kernel.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
<linux-s390@vger.kernel.org>, <martineau@kernel.org>,
<matttbe@kernel.org>, <mptcp@lists.linux.dev>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<tonylu@linux.alibaba.com>, <wenjia@linux.ibm.com>
Subject: Re: [PATCH v2 net-next] net: Deprecate SO_DEBUG and reclaim SOCK_DBG bit.
Date: Thu, 15 Feb 2024 11:39:28 -0800 [thread overview]
Message-ID: <20240215193928.11785-1-kuniyu@amazon.com> (raw)
In-Reply-To: <020edf58-c839-41c1-a302-4a75423a1761@linux.ibm.com>
From: Alexandra Winter <wintera@linux.ibm.com>
Date: Thu, 15 Feb 2024 15:14:21 +0100
> On 14.02.24 20:54, Kuniyuki Iwashima wrote:
> > + case SO_DEBUG:
> > + /* deprecated, but kept for compatibility */
> > + if (val && !sockopt_capable(CAP_NET_ADMIN))
> > + ret = -EACCES;
> > + return 0;
>
> Setting ret has no effect here. Maybe you mean something like:
> > + if (val && !sockopt_capable(CAP_NET_ADMIN))
> > + return -EACCES;
> > + return 0;
>
> or
>
> return (val && !sockopt_capable(CAP_NET_ADMIN)) ? -EACCESS : 0;
oops, thanks for catching!
will fix in v3.
next prev parent reply other threads:[~2024-02-15 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 19:54 [PATCH v2 net-next] net: Deprecate SO_DEBUG and reclaim SOCK_DBG bit Kuniyuki Iwashima
2024-02-15 9:58 ` Matthieu Baerts
2024-02-15 19:37 ` Kuniyuki Iwashima
2024-02-15 14:14 ` Alexandra Winter
2024-02-15 19:39 ` Kuniyuki Iwashima [this message]
2024-02-15 15:07 ` Jakub Kicinski
2024-02-15 16:05 ` Paolo Abeni
2024-02-15 16:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215193928.11785-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gbayer@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=linux-s390@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox