From: Heiko Carstens <hca@linux.ibm.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/2] Convert some gmap functions to use folios
Date: Tue, 26 Mar 2024 08:41:27 +0100 [thread overview]
Message-ID: <20240326074127.6078-B-hca@linux.ibm.com> (raw)
In-Reply-To: <20240322161149.2327518-1-willy@infradead.org>
On Fri, Mar 22, 2024 at 04:11:45PM +0000, Matthew Wilcox (Oracle) wrote:
> struct page is going to lose its refcount (someday) and as part of
> that page_ref_freeze() will go away. s390's ultravisor is one of
> the few remaining places that uses it, so convert it over to folios.
> From previous interactions, I understand that ultravisor doesn't support
> large folios, so this simply declines to make large folios secure.
> I think you'd be better off splitting the folio if it is large, but
> that's something I'd rather leave to someone who can test it.
>
> These patches do have the effect of making this more efficient; we lose
> at least five hidden calls to compound_head().
>
> Matthew Wilcox (Oracle) (2):
> s390: Convert make_page_secure to use a folio
> s390: Convert gmap_make_secure to use a folio
>
> arch/s390/kernel/uv.c | 50 +++++++++++++++++++++++--------------------
> 1 file changed, 27 insertions(+), 23 deletions(-)
Christian, Janosch, or Claudio, could you have a look at this please;
and provide an ACK if this is ok with you?
next prev parent reply other threads:[~2024-03-26 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 16:11 [PATCH 0/2] Convert some gmap functions to use folios Matthew Wilcox (Oracle)
2024-03-22 16:11 ` [PATCH 1/2] s390: Convert make_page_secure to use a folio Matthew Wilcox (Oracle)
2024-03-22 16:11 ` [PATCH 2/2] s390: Convert gmap_make_secure " Matthew Wilcox (Oracle)
2024-03-26 7:41 ` Heiko Carstens [this message]
2024-04-04 13:38 ` [PATCH 0/2] Convert some gmap functions to use folios Matthew Wilcox
2024-04-04 14:56 ` Claudio Imbrenda
2024-04-08 15:20 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326074127.6078-B-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox