From: Halil Pasic <pasic@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Vineeth Vijayan <vneethv@linux.ibm.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH] s390/cio: add missing MODULE_DESCRIPTION() macros
Date: Wed, 19 Jun 2024 12:32:55 +0200 [thread overview]
Message-ID: <20240619123255.4b1a6c6d.pasic@linux.ibm.com> (raw)
In-Reply-To: <afdde0842680698276df0856dd8b896dac692b56.camel@linux.ibm.com>
On Tue, 18 Jun 2024 16:11:33 -0400
Eric Farman <farman@linux.ibm.com> wrote:
> > > +MODULE_DESCRIPTION("VFIO based Physical Subchannel device
> > > driver");
> >
> > Halil/Mathew/Eric,
> > Could you please comment on this ?
>
> That's what is in the prologue, and is fine.
Eric can you explain it to me why is the attribute "physical" appropriate
here? I did a quick grep for "Physical Subchannel" only turned up hits
in vfio-ccw.
My best guess is that "physical" was somehow intended to mean the
opposite of "virtual". But actually it does not matter if our underlying
subchannel is emulated or not, at least AFAIU.
Regards,
Halil
next prev parent reply other threads:[~2024-06-19 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 3:56 [PATCH] s390/cio: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-18 12:52 ` Vineeth Vijayan
2024-06-18 20:11 ` Eric Farman
2024-06-19 10:32 ` Halil Pasic [this message]
2024-06-19 14:00 ` Eric Farman
2024-07-09 22:15 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619123255.4b1a6c6d.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=quic_jjohnson@quicinc.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox