From: Christoph Schlameuss <schlameuss@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Subject: Re: [PATCH v1 2/9] selftests: kvm: s390: Add kvm_s390_sie_block definition for userspace tests
Date: Wed, 10 Jul 2024 20:39:03 +0200 [thread overview]
Message-ID: <20240710203903.397b9ce6.schlameuss@linux.ibm.com> (raw)
In-Reply-To: <20240709174022.348db1a9@p-imbrenda.boeblingen.de.ibm.com>
On Tue, 9 Jul 2024 17:40:22 +0200
Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
> On Tue, 9 Jul 2024 14:56:57 +0200
> Christoph Schlameuss <schlameuss@linux.ibm.com> wrote:
>
> > Subsequent tests do require direct manipulation of the SIE instruction.
> > This commit introduces the SIE definition for the selftests.
> >
> > There are already definitions of this within the kernel.
> > This differs in two ways.
> > * This is the first definition of this in userspace.
> > * This does not require atomicity for the flags.
>
> you say this here,
>
> [...]
>
> > +#define PROG_BLOCK_SIE BIT(0)
> > +#define PROG_REQUEST BIT(1)
> > + atomic_t prog20; /* 0x0020 */
>
> but then you define this as atomic.
>
> Is this a mistake, or is there a good reason?
>
> [...]
Yes, this was an oversight. Will correct that to __u32 in the next version.
Christoph
next prev parent reply other threads:[~2024-07-10 18:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 12:56 [PATCH v1 0/9] selftests: kvm: s390: Add s390x ucontrol selftests Christoph Schlameuss
2024-07-09 12:56 ` [PATCH v1 1/9] selftests: kvm: s390: Define page sizes in shared header Christoph Schlameuss
2024-07-09 15:08 ` Claudio Imbrenda
2024-07-09 12:56 ` [PATCH v1 2/9] selftests: kvm: s390: Add kvm_s390_sie_block definition for userspace tests Christoph Schlameuss
2024-07-09 15:40 ` Claudio Imbrenda
2024-07-10 18:39 ` Christoph Schlameuss [this message]
2024-07-09 12:56 ` [PATCH v1 3/9] selftests: kvm: s390: Add s390x ucontrol test suite with hpage test Christoph Schlameuss
2024-07-09 15:43 ` Claudio Imbrenda
2024-07-09 12:56 ` [PATCH v1 4/9] selftests: kvm: s390: Add test fixture and simple VM setup tests Christoph Schlameuss
2024-07-09 16:17 ` Claudio Imbrenda
2024-07-09 12:57 ` [PATCH v1 5/9] selftests: kvm: s390: Add debug print functions Christoph Schlameuss
2024-07-09 16:31 ` Claudio Imbrenda
2024-07-11 12:28 ` Christoph Schlameuss
2024-07-09 12:57 ` [PATCH v1 6/9] selftests: kvm: s390: Add VM run test case Christoph Schlameuss
2024-07-09 16:52 ` Claudio Imbrenda
2024-07-09 12:57 ` [PATCH v1 7/9] selftests: kvm: s390: Add uc_map_unmap VM " Christoph Schlameuss
2024-07-09 12:57 ` [PATCH v1 8/9] selftests: kvm: s390: Add uc_skey " Christoph Schlameuss
2024-07-09 17:06 ` Claudio Imbrenda
2024-07-11 12:48 ` Christoph Schlameuss
2024-07-09 12:57 ` [PATCH v1 9/9] selftests: kvm: s390: Verify reject memory region operations for ucontrol VMs Christoph Schlameuss
2024-07-09 16:56 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710203903.397b9ce6.schlameuss@linux.ibm.com \
--to=schlameuss@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nsg@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox