From: Heiko Carstens <hca@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Florent Revest <revest@chromium.org>,
linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Mark Rutland <mark.rutland@arm.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs
Date: Mon, 16 Sep 2024 20:59:05 +0200 [thread overview]
Message-ID: <20240916185905.5704-A-hca@linux.ibm.com> (raw)
In-Reply-To: <20240916122930.523af6c5@rorschach.local.home>
On Mon, Sep 16, 2024 at 12:29:30PM -0400, Steven Rostedt wrote:
> On Mon, 16 Sep 2024 14:16:56 +0200
> Heiko Carstens <hca@linux.ibm.com> wrote:
>
> > This does not pass the ftrace selftests. Please merge the patch below
> > into this patch. With that:
> >
> > Acked-by: Heiko Carstens <hca@linux.ibm.com>
>
> Thank you very much, this is why I wanted arch maintainers acks before
> taking anything.
>
> There may be other patches in this series that I didn't Cc everyone
> (yet). Did you look at the other patches? If not, I'll go and do the Cc.
> It's a manual process.
I just had a quick look and tried Masami's git tree with the
topic/fprobe-on-fgraph branch and tried the ftrace selftests, which
resulted in the provided small fix.
But now that you ask, I can see that FPROBE is not available on s390
anymore with the full series, since HAVE_FTRACE_GRAPH_FUNC is not
available.
Also the s390 variant of arch_ftrace_fill_perf_regs() seems to be
incorrect.
Looks like some work is needed from our side.
next prev parent reply other threads:[~2024-09-16 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172615368656.133222.2336770908714920670.stgit@devnote2>
[not found] ` <172615373091.133222.1812791604518973124.stgit@devnote2>
2024-09-15 9:15 ` [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs Steven Rostedt
2024-09-16 12:16 ` Heiko Carstens
2024-09-16 16:29 ` Steven Rostedt
2024-09-16 18:59 ` Heiko Carstens [this message]
2024-10-01 12:55 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916185905.5704-A-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=ast@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox