From: Matthew Rosato <mjrosato@linux.ibm.com>
To: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
gerald.schaefer@linux.ibm.com, schnelle@linux.ibm.com
Cc: hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, borntraeger@linux.ibm.com,
farman@linux.ibm.com, clegoate@redhat.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 6/6] iommu/s390: implement def_domain_type
Date: Mon, 9 Dec 2024 14:24:03 -0500 [thread overview]
Message-ID: <20241209192403.107090-7-mjrosato@linux.ibm.com> (raw)
In-Reply-To: <20241209192403.107090-1-mjrosato@linux.ibm.com>
On s390, identity domains are only supported under certain virtualization
scenarios. If iommu passthrough is requested but unavailable for a
device, ignore the request and instead fall back to dma-iommu with a
message.
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
---
drivers/iommu/s390-iommu.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
index 18979d8109b2..6906e1b5b1b0 100644
--- a/drivers/iommu/s390-iommu.c
+++ b/drivers/iommu/s390-iommu.c
@@ -462,6 +462,28 @@ static void s390_iommu_get_resv_regions(struct device *dev,
}
}
+static int s390_iommu_def_domain_type(struct device *dev)
+{
+ struct zpci_dev *zdev = to_zpci_dev(dev);
+
+ /* If strict DMA is requested this takes priority */
+ if (iommu_dma_is_strict())
+ return IOMMU_DOMAIN_DMA;
+
+ /* DMA_FQ is the default unless passthrough is specified */
+ if (!iommu_default_passthrough())
+ return IOMMU_DOMAIN_DMA_FQ;
+
+ /* If passthrough specified, CLP must indicate it is allowed. */
+ if (zdev->rtr_avail)
+ return IOMMU_DOMAIN_IDENTITY;
+
+ /* If not allowed, fall back to using translation via DMA_FQ */
+ pr_info("Passthrough ignored, translation required for %s.\n",
+ pci_name(to_pci_dev(dev)));
+ return IOMMU_DOMAIN_DMA_FQ;
+}
+
static struct iommu_device *s390_iommu_probe_device(struct device *dev)
{
struct zpci_dev *zdev;
@@ -839,6 +861,7 @@ static const struct iommu_ops s390_iommu_ops = {
.device_group = generic_device_group,
.pgsize_bitmap = SZ_4K,
.get_resv_regions = s390_iommu_get_resv_regions,
+ .def_domain_type = s390_iommu_def_domain_type,
.default_domain_ops = &(const struct iommu_domain_ops) {
.attach_dev = s390_iommu_attach_device,
.map_pages = s390_iommu_map_pages,
--
2.47.0
prev parent reply other threads:[~2024-12-09 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 19:23 [PATCH 0/6] iommu/s390: add support for IOMMU passthrough Matthew Rosato
2024-12-09 19:23 ` [PATCH 1/6] s390/pci: check for relaxed translation capability Matthew Rosato
2024-12-09 19:23 ` [PATCH 2/6] s390: enable ARCH_HAS_PHYS_TO_DMA Matthew Rosato
2024-12-10 4:33 ` Christoph Hellwig
2024-12-10 21:23 ` Matthew Rosato
2024-12-09 19:24 ` [PATCH 3/6] iommu/s390: implement iommu passthrough via identity domain Matthew Rosato
2024-12-09 19:24 ` [PATCH 4/6] iommu: add routine to check strict setting Matthew Rosato
2024-12-09 19:24 ` [PATCH 5/6] iommu: document missing def_domain_type return Matthew Rosato
2024-12-10 2:57 ` Baolu Lu
2024-12-10 16:26 ` Matthew Rosato
2024-12-10 18:42 ` Robin Murphy
2024-12-10 22:06 ` Matthew Rosato
2024-12-11 18:42 ` Robin Murphy
2024-12-09 19:24 ` Matthew Rosato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209192403.107090-7-mjrosato@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=clegoate@redhat.com \
--cc=farman@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox