From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
nrb@linux.ibm.com, hca@linux.ibm.com
Subject: [kvm-unit-tests PATCH] lib: s390x: css: Cleanup chsc inline assembly
Date: Thu, 6 Feb 2025 14:58:49 +0000 [thread overview]
Message-ID: <20250206150128.147206-1-frankja@linux.ibm.com> (raw)
Name the CHSC command block pointer instead of naming it "p".
Also replace the two "m" constraints with a memory globber so the
constraints are easier to read.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
To me it makes more sense to have a separate commit that has a message
explaining why we changed it instead of sending a v2, so here it is.
---
lib/s390x/css.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/s390x/css.h b/lib/s390x/css.h
index 06bb59c7..167f8e83 100644
--- a/lib/s390x/css.h
+++ b/lib/s390x/css.h
@@ -364,16 +364,16 @@ bool get_chsc_scsc(void);
#define CHSC_RSP_EBUSY 0x000B
#define CHSC_RSP_MAX 0x000B
-static inline int _chsc(void *p)
+static inline int _chsc(void *com_blk)
{
int cc;
- asm volatile(" .insn rre,0xb25f0000,%2,0\n"
+ asm volatile(" .insn rre,0xb25f0000,%[com_blk],0\n"
" ipm %[cc]\n"
" srl %[cc],28\n"
- : [cc] "=d" (cc), "=m" (p)
- : "d" (p), "m" (p)
- : "cc");
+ : [cc] "=d" (cc)
+ : [com_blk] "d" (com_blk)
+ : "cc", "memory");
return cc;
}
--
2.43.0
next reply other threads:[~2025-02-06 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 14:58 Janosch Frank [this message]
2025-02-06 17:27 ` [kvm-unit-tests PATCH] lib: s390x: css: Cleanup chsc inline assembly Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206150128.147206-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox