public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Chun-Tse Shao <ctshao@google.com>
To: tmricht@linux.ibm.com
Cc: acme@kernel.org, agordeev@linux.ibm.com, gor@linux.ibm.com,
	 hca@linux.ibm.com, irogers@google.com,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	linux-s390@vger.kernel.org,  namhyung@kernel.org,
	sumanthk@linux.ibm.com,  Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf/test: Skip leader sampling for s390
Date: Fri, 28 Mar 2025 11:27:52 -0700	[thread overview]
Message-ID: <20250328182752.769662-1-ctshao@google.com> (raw)
In-Reply-To: <815e95e9-5a2d-4ef7-96bf-321fb57f42e7@linux.ibm.com>

We believe we know the problem, appreciate Stephan Eranian's investigation.
It comes from throttling. While the sampling is too high, the generic code
does not modify event scheduling. `perf_event_overflow()` simply returns 1,
and subsequently, `pmu_stop()` only stops the leader event, not the slave
events because the arch layer does not consider groups. Also, the
`event_stop()` callback only operates on a single event, not the siblings.

This would impact all architectures. Perhaps we can extend the
`evnet_stop()` callback to include a new argument to also stop the siblings.
We also welcome all suggestions and open to discuss any potential solutions.

Thanks,
CT

Cc: Stephane Eranian <eranian@google.com>

  reply	other threads:[~2025-03-28 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28  6:22 [PATCH] perf/test: Skip leader sampling for s390 Thomas Richter
2025-03-01  0:12 ` Namhyung Kim
2025-03-01  0:36   ` Ian Rogers
2025-03-03  5:53     ` Thomas Richter
2025-03-28 18:27       ` Chun-Tse Shao [this message]
2025-03-28 20:05         ` Stephane Eranian
  -- strict thread matches above, loose matches on Subject: below --
2025-09-18 21:11 Anubhav Shelat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250328182752.769662-1-ctshao@google.com \
    --to=ctshao@google.com \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=eranian@google.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox