From: Heiko Carstens <hca@linux.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] watchdog: diag288_wdt: Implement module autoload
Date: Wed, 16 Apr 2025 09:21:55 +0200 [thread overview]
Message-ID: <20250416072155.7284A2f-hca@linux.ibm.com> (raw)
In-Reply-To: <bd9de770-7e51-4ed9-bbef-2a11ad7eb1b3@roeck-us.net>
On Tue, Apr 15, 2025 at 09:51:35AM -0700, Guenter Roeck wrote:
> On 4/15/25 09:24, Heiko Carstens wrote:
> > On Thu, Apr 10, 2025 at 05:10:50AM -0700, Guenter Roeck wrote:
> > > On 4/10/25 02:50, Heiko Carstens wrote:
> > > > The s390 specific diag288_wdt watchdog driver makes use of the virtual
> > > > watchdog timer, which is available in most machine configurations.
> > > > If executing the diagnose instruction with subcode 0x288 results in an
> > > > exception the watchdog timer is not available, otherwise it is available.
> > > > ---
> > > > arch/s390/boot/startup.c | 17 ++++++++++
> > > > arch/s390/include/asm/cpufeature.h | 1 +
> > > > arch/s390/include/asm/diag288.h | 41 +++++++++++++++++++++++
> > > > arch/s390/include/asm/machine.h | 1 +
> > > > arch/s390/kernel/cpufeature.c | 5 +++
> > > > drivers/watchdog/diag288_wdt.c | 53 ++----------------------------
> > > > 6 files changed, 68 insertions(+), 50 deletions(-)
> > > > create mode 100644 arch/s390/include/asm/diag288.h
> >
> > Guenter, Wim, I assume this can/should go upstream via the s390 tree?
>
> It touches s390 core code, and you did not suggest otherwise when submitting
> the patch, so that was my assumption.
Sure, just wanted to check that everybody is fine with this.
Will apply this later to the s390 tree.
Thanks!
prev parent reply other threads:[~2025-04-16 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 9:50 [PATCH] watchdog: diag288_wdt: Implement module autoload Heiko Carstens
2025-04-10 12:10 ` Guenter Roeck
2025-04-15 16:24 ` Heiko Carstens
2025-04-15 16:51 ` Guenter Roeck
2025-04-16 7:21 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416072155.7284A2f-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=svens@linux.ibm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox