Re: [PATCH 5.15 000/276] 5.15.195-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Oct 18, 2025 at 02:38:46PM +0530, Naresh Kamboju wrote:
> On Fri, 17 Oct 2025 at 21:16, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.15.195 release.
> > There are 276 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 19 Oct 2025 14:50:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.195-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> The S390 build failed on stable-rc 5.15.195-rc1 with gcc-12, gcc-8
> and clang-21 due to following build warnings / errors.
> 
> ### Build error:
> drivers/s390/cio/device.c: In function 'purge_fn':
> drivers/s390/cio/device.c:1330:23: error: passing argument 1 of
> 'spin_lock_irq' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>  1330 |         spin_lock_irq(&sch->lock);
>       |                       ^~~~~~~~~~
>       |                       |
>       |                       spinlock_t ** {aka struct spinlock **}
> In file included from drivers/s390/cio/device.c:16:
> include/linux/spinlock.h:387:55: note: expected 'spinlock_t *' {aka
> 'struct spinlock *'} but argument is of type 'spinlock_t **' {aka
> 'struct spinlock **'}
>   387 | static __always_inline void spin_lock_irq(spinlock_t *lock)
>       |                                           ~~~~~~~~~~~~^~~~
> drivers/s390/cio/device.c:1353:25: error: passing argument 1 of
> 'spin_unlock_irq' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>  1353 |         spin_unlock_irq(&sch->lock);
>       |                         ^~~~~~~~~~
>       |                         |
>       |                         spinlock_t ** {aka struct spinlock **}
> include/linux/spinlock.h:412:57: note: expected 'spinlock_t *' {aka
> 'struct spinlock *'} but argument is of type 'spinlock_t **' {aka
> 'struct spinlock **'}
>   412 | static __always_inline void spin_unlock_irq(spinlock_t *lock)
>       |                                             ~~~~~~~~~~~~^~~~
> cc1: some warnings being treated as errors
> make[3]: *** [scripts/Makefile.build:289: drivers/s390/cio/device.o] Error 1
> 
> ### Suspecting patches
> Suspecting commit,
> 
>   s390/cio: Update purge function to unregister the unused subchannels
>   [ Upstream commit 9daa5a8795865f9a3c93d8d1066785b07ded6073 ]
> 
> 
> Build regressions: 5.15.195-rc1: S390: cio/device.c:1330:23: error:
> passing argument 1 of 'spin_lock_irq' from incompatible pointer type
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Thanks for the report, I'll go drop this from all 3 queues now.

greg k-h