From: Peter Zijlstra <peterz@infradead.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"kernel test robot" <lkp@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch V4 07/12] uaccess: Provide scoped user access regions
Date: Wed, 22 Oct 2025 16:23:59 +0200 [thread overview]
Message-ID: <20251022142359.GQ4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251022152006.4d461c8b@pumpkin>
On Wed, Oct 22, 2025 at 03:20:06PM +0100, David Laight wrote:
> I think that 'feature' should be marked as a 'bug', consider code like:
> for (; len >= sizeof (*uaddr); uaddr++; len -= sizeof (*uaddr)) {
> scoped_user_read_access(uaddr, Efault) {
> int frag_len;
> unsafe_get_user(frag_len, &uaddr->len, Efault);
> if (!frag_len)
> break;
> ...
> }
> ...
> }
>
All the scoped_* () things are for loops. break is a valid way to
terminate them.
next prev parent reply other threads:[~2025-10-22 14:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 12:49 [patch V4 00/12] uaccess: Provide and use scopes for user access Thomas Gleixner
2025-10-22 12:49 ` [patch V4 01/12] ARM: uaccess: Implement missing __get_user_asm_dword() Thomas Gleixner
2025-10-22 12:49 ` [patch V4 02/12] uaccess: Provide ASM GOTO safe wrappers for unsafe_*_user() Thomas Gleixner
2025-10-22 12:49 ` [patch V4 03/12] x86/uaccess: Use unsafe wrappers for ASM GOTO Thomas Gleixner
2025-10-22 12:49 ` [patch V4 04/12] powerpc/uaccess: " Thomas Gleixner
2025-10-22 12:49 ` [patch V4 05/12] riscv/uaccess: " Thomas Gleixner
2025-10-22 12:49 ` [patch V4 06/12] s390/uaccess: " Thomas Gleixner
2025-10-22 15:00 ` Heiko Carstens
2025-10-22 12:49 ` [patch V4 07/12] uaccess: Provide scoped user access regions Thomas Gleixner
2025-10-22 14:20 ` David Laight
2025-10-22 14:23 ` Peter Zijlstra [this message]
2025-10-22 12:49 ` [patch V4 08/12] uaccess: Provide put/get_user_scoped() Thomas Gleixner
2025-10-22 12:49 ` [patch V4 09/12] [RFC] coccinelle: misc: Add scoped_$MODE_access() checker script Thomas Gleixner
2025-10-22 12:49 ` [patch V4 10/12] futex: Convert to scoped user access Thomas Gleixner
2025-10-22 15:16 ` Linus Torvalds
2025-10-23 18:44 ` Thomas Gleixner
2025-10-23 19:26 ` Linus Torvalds
2025-10-23 21:14 ` David Laight
2025-10-22 12:49 ` [patch V4 11/12] x86/futex: " Thomas Gleixner
2025-10-22 12:49 ` [patch V4 12/12] select: " Thomas Gleixner
2025-10-22 13:28 ` [patch V4 00/12] uaccess: Provide and use scopes for " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022142359.GQ4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Julia.Lawall@inria.fr \
--cc=andrealmeid@igalia.com \
--cc=andrew.cooper3@citrix.com \
--cc=borntraeger@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave@stgolabs.net \
--cc=david.laight.linux@gmail.com \
--cc=dvhart@infradead.org \
--cc=hca@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mpe@ellerman.id.au \
--cc=nicolas.palix@imag.fr \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox