From: Heiko Carstens <hca@linux.ibm.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/cmm: Use max to simplify cmm_timer_fn
Date: Mon, 22 Dec 2025 11:57:26 +0100 [thread overview]
Message-ID: <20251222105726.16440Adf-hca@linux.ibm.com> (raw)
In-Reply-To: <20251222103917.635026-2-thorsten.blum@linux.dev>
Thorsten,
On Mon, Dec 22, 2025 at 11:39:17AM +0100, Thorsten Blum wrote:
> Use max() to replace the open-coded version and simplify cmm_timer_fn().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/s390/mm/cmm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
...
> nr = cmm_timed_pages_target - cmm_timeout_pages;
> - if (nr < 0)
> - cmm_timed_pages_target = 0;
> - else
> - cmm_timed_pages_target = nr;
> + cmm_timed_pages_target = max(0, nr);
Just in case it wasn't clear in the past: trivial patches like this won't be
taken. You already managed to send buggy patches which look trivial, and I'm
not willing to spend time to look for subtle bugs such trivial patches might
introduce.
In other words: you may stop sending such patches which address s390 code.
prev parent reply other threads:[~2025-12-22 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 10:39 [PATCH] s390/cmm: Use max to simplify cmm_timer_fn Thorsten Blum
2025-12-22 10:57 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222105726.16440Adf-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox