public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	borntraeger@de.ibm.com, frankja@linux.ibm.com, nsg@linux.ibm.com,
	nrb@linux.ibm.com, seiden@linux.ibm.com, gra@linux.ibm.com,
	schlameuss@linux.ibm.com, hca@linux.ibm.com, svens@linux.ibm.com,
	agordeev@linux.ibm.com, gor@linux.ibm.com, david@redhat.com,
	gerald.schaefer@linux.ibm.com
Subject: [PATCH v6 03/28] s390: Make UV folio operations work on whole folio
Date: Mon, 22 Dec 2025 17:50:08 +0100	[thread overview]
Message-ID: <20251222165033.162329-4-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20251222165033.162329-1-imbrenda@linux.ibm.com>

uv_destroy_folio() and uv_convert_from_secure_folio() should work on
all pages in the folio, not just the first one.

This was fine until now, but it will become a problem with upcoming
patches.

Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
 arch/s390/kernel/uv.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index ed46950be86f..ca0849008c0d 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -134,14 +134,15 @@ static int uv_destroy(unsigned long paddr)
  */
 int uv_destroy_folio(struct folio *folio)
 {
+	unsigned long i;
 	int rc;
 
-	/* Large folios cannot be secure */
-	if (unlikely(folio_test_large(folio)))
-		return 0;
-
 	folio_get(folio);
-	rc = uv_destroy(folio_to_phys(folio));
+	for (i = 0; i < (1 << folio_order(folio)); i++) {
+		rc = uv_destroy(folio_to_phys(folio) + i * PAGE_SIZE);
+		if (rc)
+			break;
+	}
 	if (!rc)
 		clear_bit(PG_arch_1, &folio->flags.f);
 	folio_put(folio);
@@ -183,14 +184,15 @@ EXPORT_SYMBOL_GPL(uv_convert_from_secure);
  */
 int uv_convert_from_secure_folio(struct folio *folio)
 {
+	unsigned long i;
 	int rc;
 
-	/* Large folios cannot be secure */
-	if (unlikely(folio_test_large(folio)))
-		return 0;
-
 	folio_get(folio);
-	rc = uv_convert_from_secure(folio_to_phys(folio));
+	for (i = 0; i < (1 << folio_order(folio)); i++) {
+		rc = uv_convert_from_secure(folio_to_phys(folio) + i * PAGE_SIZE);
+		if (rc)
+			break;
+	}
 	if (!rc)
 		clear_bit(PG_arch_1, &folio->flags.f);
 	folio_put(folio);
-- 
2.52.0


  parent reply	other threads:[~2025-12-22 16:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 16:50 [PATCH v6 00/28] KVM: s390: gmap rewrite, the real deal Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 01/28] KVM: s390: Refactor pgste lock and unlock functions Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 02/28] KVM: s390: add P bit in table entry bitfields, move union vaddress Claudio Imbrenda
2025-12-22 16:50 ` Claudio Imbrenda [this message]
2025-12-22 16:50 ` [PATCH v6 04/28] s390: Move sske_frame() to a header Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 05/28] KVM: s390: Add gmap_helper_set_unused() Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 06/28] KVM: s390: Introduce import_lock Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 07/28] KVM: s390: Export two functions Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 08/28] s390/mm: Warn if uv_convert_from_secure_pte() fails Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 09/28] KVM: s390: vsie: Pass gmap explicitly as parameter Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 10/28] KVM: s390: Enable KVM_GENERIC_MMU_NOTIFIER Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 11/28] KVM: s390: Rename some functions in gaccess.c Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 12/28] KVM: s390: KVM-specific bitfields and helper functions Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 13/28] KVM: s390: KVM page table management functions: allocation Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 14/28] KVM: s390: KVM page table management functions: clear and replace Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 15/28] KVM: s390: KVM page table management functions: walks Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 16/28] KVM: s390: KVM page table management functions: storage keys Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 17/28] KVM: s390: KVM page table management functions: lifecycle management Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 18/28] KVM: s390: KVM page table management functions: CMMA Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 19/28] KVM: s390: New gmap code Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 20/28] KVM: s390: Add helper functions for fault handling Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 21/28] KVM: s390: Add some helper functions needed for vSIE Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 22/28] KVM: s390: Stop using CONFIG_PGSTE Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 23/28] KVM: s390: Storage key functions refactoring Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 24/28] KVM: s390: Switch to new gmap Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 25/28] KVM: s390: Remove gmap from s390/mm Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 26/28] KVM: S390: Remove PGSTE code from linux/s390 mm Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 27/28] KVM: s390: Enable 1M pages for gmap Claudio Imbrenda
2025-12-22 16:50 ` [PATCH v6 28/28] KVM: s390: Storage key manipulation IOCTL Claudio Imbrenda
2026-01-14  9:33   ` Christoph Schlameuss
2026-01-14  9:53     ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251222165033.162329-4-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=gra@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=schlameuss@linux.ibm.com \
    --cc=seiden@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox