From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
borntraeger@linux.ibm.com, hca@linux.ibm.com
Subject: [PATCH 1/3] KVM: s390: selftests: Add load psw bear test
Date: Thu, 23 Apr 2026 12:36:02 +0000 [thread overview]
Message-ID: <20260423123902.14663-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20260423123902.14663-1-frankja@linux.ibm.com>
The bear is set for lpsw and lpswe, so let's check that also happens
when kvm emulates these instructions.
Load PSW and all of its variants are only emulated by KVM if there's a
pending machine check. Therefore the tests inject those but never open
the masks to receive them.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
tools/testing/selftests/kvm/Makefile.kvm | 1 +
tools/testing/selftests/kvm/s390/bear.c | 250 +++++++++++++++++++++++
2 files changed, 251 insertions(+)
create mode 100644 tools/testing/selftests/kvm/s390/bear.c
diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
index 6471fa214a9f..9afb6479dbee 100644
--- a/tools/testing/selftests/kvm/Makefile.kvm
+++ b/tools/testing/selftests/kvm/Makefile.kvm
@@ -207,6 +207,7 @@ TEST_GEN_PROGS_s390 += s390/user_operexec
TEST_GEN_PROGS_s390 += s390/keyop
TEST_GEN_PROGS_s390 += rseq_test
TEST_GEN_PROGS_s390 += s390/irq_routing
+TEST_GEN_PROGS_s390 += s390/bear
TEST_GEN_PROGS_riscv = $(TEST_GEN_PROGS_COMMON)
TEST_GEN_PROGS_riscv += riscv/sbi_pmu_test
diff --git a/tools/testing/selftests/kvm/s390/bear.c b/tools/testing/selftests/kvm/s390/bear.c
new file mode 100644
index 000000000000..63032a789c8d
--- /dev/null
+++ b/tools/testing/selftests/kvm/s390/bear.c
@@ -0,0 +1,250 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* LPSW/E bear tests. */
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/ioctl.h>
+
+#include "test_util.h"
+#include "kvm_util.h"
+#include "kselftest.h"
+#include "ucall_common.h"
+#include "facility.h"
+#include "processor.h"
+
+u64 psw_mask = 0x0400000180000000ULL;
+
+static void guest_lpswe_inv(void)
+{
+ extern void lpswe_dest_addr_inv(void);
+ u64 psw_inv[2] = {psw_mask | BIT(63), (uintptr_t)lpswe_dest_addr_inv};
+ u64 psw_pgm[2] = {psw_mask, (uintptr_t)lpswe_dest_addr_inv};
+ u64 bear;
+
+ /*
+ * Advanced shenanigans:
+ * - Use real stores (sturg) to lowcore PGM new PSW since the
+ * lowcore isn't mapped in DAT
+ * - After the exception store invalid address to PGM new so
+ * the test exits
+ */
+ asm volatile (
+ " larl %%r3,lpswe_addr_inv\n"
+ " lghi %%r6, 464\n"
+ " lg %%r5, %[psw_pgm_m]\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r6, 472\n"
+ " lg %%r5, %[psw_pgm_a]\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r5, 0x80\n"
+ " xgr %%r6, %%r6\n"
+ " sturg %%r5, %%r6\n"
+ "lpswe_addr_inv:\n"
+ " lpswe %[psw_inv]\n"
+ " nop\n"
+ " nop\n"
+ ".globl lpswe_dest_addr_inv\n"
+ "lpswe_dest_addr_inv:\n"
+ " .insn s,0xb2010000,%[bear]\n"
+ " lg %%r4, %[bear]\n"
+ " lghi %%r6, 472\n"
+ " lghi %%r5, 1\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r6, 0x8c\n"
+ " lura %%r5, %%r6\n"
+ : [bear] "=Q" (bear)
+ : [psw_inv] "Q" (psw_inv),
+ [psw_pgm_m] "Q" (psw_pgm), [psw_pgm_a] "Q" (psw_pgm[1])
+ : "cc", "r3", "r4", "r5", "r6"
+ );
+}
+
+static void guest_lpswe(void)
+{
+ extern void lpswe_dest_addr(void);
+ u64 psw[2] = {psw_mask, (uintptr_t)lpswe_dest_addr};
+ u64 bear;
+
+ asm volatile (
+ " larl %%r3,lpswe_addr\n"
+ "lpswe_addr:\n"
+ " lpswe %[psw]\n"
+ " nop\n"
+ " nop\n"
+ ".globl lpswe_dest_addr\n"
+ "lpswe_dest_addr:\n"
+ " .insn s,0xb2010000,%[bear]\n"
+ " lg %%r4, %[bear]\n"
+ " nop\n"
+ " nop\n"
+ : [bear] "=Q" (bear)
+ : [psw] "Q" (psw)
+ : "cc", "r3", "r4"
+ );
+}
+
+static void guest_lpsw(void)
+{
+ extern void lpsw_dest_addr(void);
+ u64 psw_short = (psw_mask | BIT(63 - 12) | (uintptr_t)lpsw_dest_addr);
+ u64 bear;
+
+ asm volatile (
+ " larl %%r3,lpsw_addr\n"
+ "lpsw_addr:\n"
+ " lpsw %[psw]\n"
+ " nop\n"
+ " nop\n"
+ ".globl lpsw_dest_addr\n"
+ "lpsw_dest_addr:\n"
+ " .insn s,0xb2010000,%[bear]\n"
+ " lg %%r4, %[bear]\n"
+ " nop\n"
+ " nop\n"
+ : [bear] "=Q" (bear)
+ : [psw] "Q" (psw_short)
+ : "cc", "r3", "r4"
+ );
+}
+
+static void guest_lpsw_inv(void)
+{
+ extern void lpsw_dest_addr_inv(void);
+ u64 psw_short_inv = (psw_mask | BIT(63 - 12) | BIT(63) | (uintptr_t)lpsw_dest_addr_inv);
+ u64 psw_pgm[2] = {psw_mask, (uintptr_t)lpsw_dest_addr_inv};
+ u64 bear;
+
+ /*
+ * Advanced shenanigans:
+ * - Use real stores (sturg) to lowcore PGM new PSW since the
+ * lowcore isn't mapped in DAT
+ * - After the exception store invalid address to PGM new so
+ * the test exits
+ */
+ asm volatile (
+ " larl %%r3,lpsw_addr_inv\n"
+ " lghi %%r6, 464\n"
+ " lg %%r5, %[psw_pgm_m]\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r6, 472\n"
+ " lg %%r5, %[psw_pgm_a]\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r5, 0x80\n"
+ " xgr %%r6, %%r6\n"
+ " sturg %%r5, %%r6\n"
+ "lpsw_addr_inv:\n"
+ " lpsw %[psw_inv]\n"
+ " nop\n"
+ " nop\n"
+ ".globl lpsw_dest_addr_inv\n"
+ "lpsw_dest_addr_inv:\n"
+ " .insn s,0xb2010000,%[bear]\n"
+ " lg %%r4, %[bear]\n"
+ " lghi %%r6, 472\n"
+ " lghi %%r5, 1\n"
+ " sturg %%r5, %%r6\n"
+ " lghi %%r6, 0x8c\n"
+ " lura %%r5, %%r6\n"
+ : [bear] "=Q" (bear)
+ : [psw_inv] "Q" (psw_short_inv),
+ [psw_pgm_m] "Q" (psw_pgm), [psw_pgm_a] "Q" (psw_pgm[1])
+ : "cc", "r3", "r4", "r5", "r6"
+ );
+}
+
+/* A machine check forces KVM to emulate PSW loading */
+static void inject_mcheck(struct kvm_vcpu *vcpu)
+{
+ struct kvm_s390_irq irq = {};
+ int irqs;
+
+ irq.type = KVM_S390_MCHK;
+ /* External damage mcheck */
+ irq.u.mchk.cr14 = BIT(63 - 38);
+ irq.u.mchk.mcic = BIT(58);
+ irqs = __vcpu_ioctl(vcpu, KVM_S390_IRQ, &irq);
+ TEST_ASSERT(irqs >= 0, "Error injecting MCHECK errno %d", errno);
+}
+
+static void test_lpswe(void)
+{
+ struct kvm_vcpu *vcpu;
+ struct kvm_run *run;
+ struct kvm_vm *vm;
+ void *lc;
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpswe);
+ inject_mcheck(vcpu);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpswe: emulation: bear matches\n");
+ kvm_vm_free(vm);
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpswe_inv);
+ lc = addr_gpa2hva(vm, 0);
+ memset(lc, 0, PAGE_SIZE);
+ inject_mcheck(vcpu);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpswe: emulation: pgm: lpsw bear matches\n");
+ ksft_test_result(run->s.regs.gprs[5] == 6,
+ "lpswe: emulation: pgm: ILC is 0\n");
+ kvm_vm_free(vm);
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpsw);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] &&
+ run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpswe: interpretation: lpswe bear matches\n");
+ kvm_vm_free(vm);
+}
+
+static void test_lpsw(void)
+{
+ struct kvm_vcpu *vcpu;
+ struct kvm_run *run;
+ struct kvm_vm *vm;
+ void *lc;
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpsw);
+ inject_mcheck(vcpu);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpsw: emulation: bear matches\n");
+ kvm_vm_free(vm);
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpsw_inv);
+ lc = addr_gpa2hva(vm, 0);
+ memset(lc, 0, PAGE_SIZE);
+ inject_mcheck(vcpu);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpsw: emulation: pgm: invalid: bear matches\n");
+ ksft_test_result(run->s.regs.gprs[5] == 6,
+ "lpsw: emulation: pgm: ILC is 0\n");
+ kvm_vm_free(vm);
+
+ vm = vm_create_with_one_vcpu(&vcpu, guest_lpsw);
+ run = vcpu->run;
+ vcpu_run(vcpu);
+ ksft_test_result(run->s.regs.gprs[3] &&
+ run->s.regs.gprs[3] == run->s.regs.gprs[4],
+ "lpsw: interpretation: bear matches\n");
+ kvm_vm_free(vm);
+}
+
+int main(int argc, char *argv[])
+{
+ TEST_REQUIRE(test_facility(193));
+
+ ksft_print_header();
+ ksft_set_plan(8);
+ test_lpsw();
+ test_lpswe();
+ ksft_finished();
+}
--
2.51.0
next prev parent reply other threads:[~2026-04-23 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 12:36 [PATCH 0/3] KVM: s390: Additional LPSW/E fixes Janosch Frank
2026-04-23 12:36 ` Janosch Frank [this message]
2026-04-23 12:36 ` [PATCH 2/3] kvm: s390: Fix LPSW/E early exception bear behavior Janosch Frank
2026-04-23 12:36 ` [PATCH 3/3] kvm: s390: Fix lpsw/e spec exception ilc reporting Janosch Frank
2026-04-23 13:36 ` Heiko Carstens
2026-04-23 14:12 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423123902.14663-2-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox