Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Jan Polensky <japo@linux.ibm.com>
To: hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
	ojeda@kernel.org, peterz@infradead.org, jpoimboe@kernel.org,
	jbaron@akamai.com, aliceryhl@google.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, boqun@kernel.org,
	gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
	a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org,
	rostedt@goodmis.org, ardb@kernel.org, linux-s390@vger.kernel.org,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/6] rust: helpers: Use __builtin_memchr directly on s390
Date: Fri, 29 May 2026 16:57:50 +0200	[thread overview]
Message-ID: <20260529145752.1209016-5-japo@linux.ibm.com> (raw)
In-Reply-To: <20260529145752.1209016-1-japo@linux.ibm.com>

The __underlying_memchr macro from include/linux/fortify-string.h
is not being expanded correctly during Rust helpers compilation on
s390x architecture, causing a build failure:

  rust/helpers/uaccess.c:40:16: error: implicit declaration of
  function '__underlying_memchr'

The macro is defined as __builtin_memchr, so use the builtin
directly instead of relying on the macro expansion.

Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Signed-off-by: Jan Polensky <japo@linux.ibm.com>
---
 rust/helpers/uaccess.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/rust/helpers/uaccess.c b/rust/helpers/uaccess.c
index d9625b9ee046..d4107426003e 100644
--- a/rust/helpers/uaccess.c
+++ b/rust/helpers/uaccess.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0

 #include <linux/uaccess.h>
+#include <linux/string.h>

 __rust_helper unsigned long
 rust_helper_copy_from_user(void *to, const void __user *from, unsigned long n)
@@ -27,3 +28,9 @@ unsigned long rust_helper__copy_to_user(void __user *to, const void *from, unsig
 	return _inline_copy_to_user(to, from, n);
 }
 #endif
+
+__rust_helper
+void *rust_helper_memchr(const void *s, int c, size_t n)
+{
+	return __builtin_memchr(s, c, n);
+}
--
2.53.0


  parent reply	other threads:[~2026-05-29 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 14:57 [PATCH v4 0/6] s390: Enable Rust support and add required arch glue Jan Polensky
2026-05-29 14:57 ` [PATCH v4 1/6] s390/bug: Provide ARCH_WARN_ASM for Rust WARN/BUG support Jan Polensky
2026-05-29 14:57 ` [PATCH v4 2/6] s390/jump_label: Implement ARCH_STATIC_BRANCH_JUMP_ASM and ARCH_STATIC_BRANCH_ASM macros Jan Polensky
2026-05-29 14:57 ` [PATCH v4 3/6] rust/bindgen_parameters: Mark s390 types as opaque to prevent repr conflicts Jan Polensky
2026-05-29 14:57 ` Jan Polensky [this message]
2026-05-29 14:57 ` [PATCH v4 5/6] s390/cmpxchg: Fix KASAN stack-out-of-bounds in atomic helpers Jan Polensky
2026-05-29 16:55   ` Miguel Ojeda
2026-05-29 14:57 ` [PATCH v4 6/6] s390: Enable Rust support Jan Polensky
2026-05-29 16:56 ` [PATCH v4 0/6] s390: Enable Rust support and add required arch glue Miguel Ojeda
2026-06-01 17:44   ` Jan Polensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529145752.1209016-5-japo@linux.ibm.com \
    --to=japo@linux.ibm.com \
    --cc=a.hindborg@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=aliceryhl@google.com \
    --cc=ardb@kernel.org \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox