Re: [PATCH -next] s390/idle: Add missing EXPORT_SYMBOL()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Export License Discrepancy: arch_kcpustat_field_idle and arch_kcpustat_field_iowait are exported via EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL.
--

commit 53dd63a70164da468386d3191eb1e7e24af1b440
Author: Heiko Carstens <hca@linux.ibm.com>

s390/idle: Add missing EXPORT_SYMBOL()
    
This commit fixes a build breakage for the ledtrig-activity module by
exporting the newly introduced arch_kcpustat_field_idle and
arch_kcpustat_field_iowait functions.

Closes: https://lore.kernel.org/r/ajKsG0JP6qTssQBX@monoceros

> diff --git a/arch/s390/kernel/idle.c b/arch/s390/kernel/idle.c
> index 7f7851c001e0a..6da8ee22a1d53 100644
> --- a/arch/s390/kernel/idle.c
> +++ b/arch/s390/kernel/idle.c

[ ... ]

> @@ -83,11 +84,13 @@ u64 arch_kcpustat_field_idle(int cpu)
>  {
>  	return arch_cpu_idle_time(cpu, CPUTIME_IDLE, !nr_iowait_cpu(cpu));
>  }
> +EXPORT_SYMBOL(arch_kcpustat_field_idle);

[Severity: Low]
Should this use EXPORT_SYMBOL_GPL() instead? The generic implementations of 
kcpustat_field_idle() in kernel/sched/cputime.c are exported as GPL-only.
Using a standard export here circumvents the GPL symbol restriction imposed
by the core scheduler.

>  
>  u64 arch_kcpustat_field_iowait(int cpu)
>  {
>  	return arch_cpu_idle_time(cpu, CPUTIME_IOWAIT, nr_iowait_cpu(cpu));
>  }
> +EXPORT_SYMBOL(arch_kcpustat_field_iowait);

[Severity: Low]
Similarly, does this need to be EXPORT_SYMBOL_GPL() to match the generic
kcpustat_field_iowait() counterpart?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617145313.3910957-1-hca@linux.ibm.com?part=1