Re: [RFC PATCH] net/iucv: Descend into net/iucv when AFIUCV is enabled

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undefined reference to `iucv_if` when linking `vmlinux` if `CONFIG_AFIUCV=y` and `CONFIG_IUCV=m`.
--

commit f5dfba2251234de82ea8d770ca96db4b3b823733
Author: Pengpeng Hou <pengpeng@iscas.ac.cn>
net/iucv: Descend into net/iucv when AFIUCV is enabled

This commit modifies the top-level network Makefile to unconditionally descend
into the net/iucv directory. It allows af_iucv.o to be evaluated when
CONFIG_AFIUCV is selected without the base IUCV object.

> diff --git a/net/Makefile b/net/Makefile
> index 5b2dd7f07a85e..c0da946b281e1 100644
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -45,7 +45,7 @@ obj-$(CONFIG_WIRELESS)		+= wireless/
>  obj-$(CONFIG_MAC80211)		+= mac80211/
>  obj-$(CONFIG_TIPC)		+= tipc/
>  obj-$(CONFIG_NETLABEL)		+= netlabel/
> -obj-$(CONFIG_IUCV)		+= iucv/
> +obj-y				+= iucv/

[Severity: Low]
Does this create a linker error when CONFIG_AFIUCV=y and CONFIG_IUCV=m?

Because of this unconditional descent, af_iucv.o can be evaluated and built
into vmlinux even when IUCV is configured as a module.

In afiucv_init(), if CONFIG_IUCV=m, IS_ENABLED(CONFIG_IUCV) evaluates to 1:

net/iucv/af_iucv.c:afiucv_init() {
	...
	if (machine_is_vm() && IS_ENABLED(CONFIG_IUCV)) {
		cpcmd("QUERY USERID", iucv_userid, sizeof(iucv_userid), &err);
		if (unlikely(err)) {
			WARN_ON(err);
			err = -EPROTONOSUPPORT;
			goto out;
		}

		pr_iucv = &iucv_if;
	} else {
	...
}

Will this cause an undefined reference to the module-bound iucv_if symbol when
linking vmlinux?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625061303.36326-1-pengpeng@iscas.ac.cn?part=1