Re: [PATCH v3] perf test: perftool-testsuite-report fails on s390

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces a divergent configuration state where user/system configurations are strictly ignored on s390x but loaded on all other architectures.
--

--- Patch [1]: [PATCH v3] perf test: perftool-testsuite-report fails on s390 ---
commit 01af4a3a83b9a4ed0f3f18651c07cbbbdda377c8
Author: Thomas Richter <tmricht@linux.ibm.com>

perf test: perftool-testsuite-report fails on s390

This commit modifies the perftool-testsuite-report test script to address
failures on s390 caused by addr2line timeouts. It creates a temporary
perf configuration file to disable addr2line warnings specifically on the
s390x architecture.

> diff --git a/tools/perf/tests/shell/perftool-testsuite_report.sh b/tools/perf/tests/shell/perftool-testsuite_report.sh
> index a8cf75b4e77ec..01116f8d71ce6 100755
> --- a/tools/perf/tests/shell/perftool-testsuite_report.sh
> +++ b/tools/perf/tests/shell/perftool-testsuite_report.sh
> @@ -6,6 +6,16 @@ test -d "$(dirname "$0")/base_report" || exit 2
>  cd "$(dirname "$0")/base_report" || exit 2
>  status=0
>  
> +# On s390 the default timeout for addr2line is too short, disable warnings
> +if [ $(uname -m) = s390x ]
> +then
> +	perf_config_tmp=$(mktemp /tmp/.perfconfig_XXXXX)
> +	export PERF_CONFIG="${perf_config_tmp}"

[Severity: Medium]
Does this introduce a divergent configuration state between architectures?

By exporting PERF_CONFIG to a temporary file on s390x, perf is instructed
to read only that file, ignoring the user's ~/.perfconfig and system
/etc/perfconfig.

On other architectures, PERF_CONFIG is left unmodified, meaning user and
system configurations are still applied. This architectural divergence
isolates the test environment on s390x but leaves it exposed to arbitrary
user settings on other platforms.

> +	perf config 'core.addr2line-disable-warn = true'
> +else
> +	perf_config_tmp=""
> +fi

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709090136.1031645-1-tmricht@linux.ibm.com?part=1