Re: [PATCH 11/21] KVM: s390: vsie: Create helpers to alloc and free vsie_pages

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused parameter 'kvm' in newly added function `alloc_vsie_page`.
--

--- Patch [11]: [PATCH 11/21] KVM: s390: vsie: Create helpers to alloc and free vsie_pages ---
commit c4b88feb6783fb127e24e97af58ad89ffa8ef444
Author: Christoph Schlameuss <schlameuss@linux.ibm.com>

KVM: s390: vsie: Create helpers to alloc and free vsie_pages
    
This commit extracts the allocation and freeing of vsie_page structures
into dedicated helper functions. This encapsulation allows these operations
to be reused across multiple code paths.

> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index 5bdd9385266f0..4090b4019f215 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c

[ ... ]

> +static void free_vsie_page(struct vsie_page *vsie_page)
> +{
> +	free_page((unsigned long)vsie_page);
> +}
> +
> +static struct vsie_page *alloc_vsie_page(struct kvm *kvm)
> +{
> +	struct vsie_page *vsie_page;
> +
> +	vsie_page = (struct vsie_page *)__get_free_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO | GFP_DMA);

[Severity: Low]
Does this function actually need the kvm parameter? It appears to be completely
unused inside the function body.

> +	if (!vsie_page)
> +		return vsie_page;
> +
> +	/* Mark it as invalid until it resides in the tree. */
> +	vsie_page->scb_gpa = ULONG_MAX;
> +	return vsie_page;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-vsie-sigpi-v1-0-ea9f12066408@linux.ibm.com?part=11