Re: [PATCH 1/2] ptp: ptp_s390: Add missing CC check for ptff()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message explicitly states "returning EIO if it is not zero", but the implementation actually returns `-EOPNOTSUPP`.
--

--- Patch [1]: [PATCH 1/2] ptp: ptp_s390: Add missing CC check for ptff() ---
commit 1da4a31377dcdb1f0789c86ae0f57516f6c5caf1
Author: Sven Schnelle <svens@linux.ibm.com>

ptp: ptp_s390: Add missing CC check for ptff()

This commit updates ptp_s390_qpt_gettime to check the condition code
returned by ptff. It adds an error path to handle non-zero returns from
the hardware call.

> The code doesn't honor the returned condition code when issuing
> the PTFF_QPT call. Fix this by checking the return code and returning
> EIO if it is not zero.

[Severity: Medium]
Is the description in the commit message accurate? The message states the
code returns EIO, but the implementation actually returns -EOPNOTSUPP:

> diff --git a/drivers/ptp/ptp_s390.c b/drivers/ptp/ptp_s390.c
> index 29618eb9bf442..7299c3aae65f6 100644
> --- a/drivers/ptp/ptp_s390.c
> +++ b/drivers/ptp/ptp_s390.c
> @@ -48,7 +48,8 @@ static int ptp_s390_qpt_gettime(struct ptp_clock_info *ptp,
>  {
>  	unsigned long tod;
>  
> -	ptff(&tod, sizeof(tod), PTFF_QPT);
> +	if (ptff(&tod, sizeof(tod), PTFF_QPT) != 0)
> +		return -EOPNOTSUPP;
>  	*ts = tod_to_timespec64(tod);
>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714084921.3926697-1-svens@linux.ibm.com?part=1