From: sashiko-bot@kernel.org
To: "Christian Borntraeger" <borntraeger@de.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [GIT PULL 3/5] KVM: s390: Fix dat_crste_walk_range() early return
Date: Mon, 27 Jul 2026 10:02:20 +0000 [thread overview]
Message-ID: <20260727100221.7437F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727095359.107671-4-borntraeger@de.ibm.com>
> From: Claudio Imbrenda <imbrenda@linux.ibm.com>
>
> If a walk entry handler for a lower level returns a value,
> dat_crste_walk_range() will not return immediately, but instead loop
> again and move to the next entry.
>
> This means that some entries are potentially skipped, and early return
> is ignored. Skipped entries might lead to all kinds of issues, given
> that the caller expects them to not be skipped. Early return is often
> used to interrupt a walk when a rescheduling is needed; if it is
> ignored it can lead to stalls.
>
> Fix by breaking from the loop immediately if the walk to a lower level
> returned non-zero.
>
> Fixes: 2db149a0a6c5 ("KVM: s390: KVM page table management functions: walks")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727095359.107671-4-borntraeger@de.ibm.com?part=1
next prev parent reply other threads:[~2026-07-27 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:53 [GIT PULL 0/5] KVM: s390: Fixes for 7.2 Christian Borntraeger
2026-07-27 9:53 ` [GIT PULL 1/5] KVM: s390: pci: Fix GISC refcount leak on AIF enable failure Christian Borntraeger
2026-07-27 10:08 ` sashiko-bot
2026-07-27 9:53 ` [GIT PULL 2/5] KVM: s390: vsie: Avoid potential deadlock with real spaces Christian Borntraeger
2026-07-27 10:06 ` sashiko-bot
2026-07-27 9:53 ` [GIT PULL 3/5] KVM: s390: Fix dat_crste_walk_range() early return Christian Borntraeger
2026-07-27 10:02 ` sashiko-bot [this message]
2026-07-27 9:53 ` [GIT PULL 4/5] KVM: s390: Improve kvm_s390_vm_stop_migration() Christian Borntraeger
2026-07-27 10:06 ` sashiko-bot
2026-07-27 9:53 ` [GIT PULL 5/5] KVM: s390: pci: Fix handling of AIF enable without AISB Christian Borntraeger
2026-07-27 10:09 ` sashiko-bot
2026-07-27 9:55 ` [GIT PULL 0/5] KVM: s390: Fixes for 7.2 Christian Borntraeger
-- strict thread matches above, loose matches on Subject: below --
2026-07-13 8:30 Christian Borntraeger
2026-07-13 8:30 ` [GIT PULL 3/5] KVM: s390: Fix dat_crste_walk_range() early return Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727100221.7437F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox