Re: [PATCH v2 3/3] sparc: Implement arch_do_panic

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The function `arch_do_panic` is defined without a visible prototype, triggering a `-Wmissing-prototypes` compiler warning.
- [Low] Redundant local `extern` declaration of `stop_a_enabled`.
--

--- Patch [3]: [PATCH v2 3/3] sparc: Implement arch_do_panic ---
commit ab46dd14f9e80619721232e0fc090eea0709afa1
Author: Mete Durlu <meted@linux.ibm.com>

sparc: Implement arch_do_panic

Implement sparc specific arch_do_panic() instead of using sparc specific
ifdef sections in vpanic() code.

> diff --git a/arch/sparc/kernel/setup.c b/arch/sparc/kernel/setup.c
> index 4975867d9001b..87d3569c520f8 100644
> --- a/arch/sparc/kernel/setup.c
> +++ b/arch/sparc/kernel/setup.c

[ ... ]

> @@ -36,6 +36,14 @@ static const struct ctl_table sparc_sysctl_table[] = {
>  #endif
>  };
>  
> +void arch_do_panic(void)

[Severity: Low]
Does this trigger a -Wmissing-prototypes compiler warning? The patch
declares arch_do_panic() in arch/sparc/include/asm/bug.h, but fails to
include that header (or linux/bug.h) here where the function is actually
implemented. 

While it might appear that asm/setup.h indirectly includes linux/bug.h
via linux/interrupt.h -> linux/jump_label.h, the jump_label.h header
only includes linux/bug.h if CONFIG_JUMP_LABEL is disabled. If enabled,
the indirect inclusion path is broken. Could we add a direct include of
linux/bug.h or asm/bug.h to ensure safety across all configurations?

> +{
> +	extern int stop_a_enabled;

[Severity: Low]
Is this local extern declaration still needed? Because
arch/sparc/kernel/setup.c directly includes asm/setup.h at the top of the
file, stop_a_enabled is already globally declared for all configurations.

Could we remove this redundant block-scope declaration that was leftover
from when the code resided in kernel/panic.c?

> +	/* Make sure the user can actually press Stop-A (L1-A) */
> +	stop_a_enabled = 1;
> +	pr_emerg("Press Stop-A (L1-A) from sun keyboard or send break\n"
> +		 "twice on console to return to the boot prom\n");
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-arch_do_panic-v2-0-4e25ceb05075@linux.ibm.com?part=3