From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
bpf@vger.kernel.org, linux-s390@vger.kernel.org,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 6/6] s390/Kconfig: Select ARCH_SUPPORTS_CFI
Date: Mon, 27 Jul 2026 14:39:12 +0000 [thread overview]
Message-ID: <20260727143913.452E51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727140514.116501-7-hca@linux.ibm.com>
> With all prerequisites in place select ARCH_SUPPORTS_CFI.
>
> Note that this support is supposed to work with the generic kCFI support
> which is provided by clang. This comes with a couple of limitations:
>
> The generic kCFI implementation does not generate a .kcfi_traps section,
> nor is a special instruction used in case a checksum mismatch is detected.
>
> This means in case of checksum mismatch the kernel just crashes. It should
> be quite easy to tell by the surrounding code that a crash happened because
> of a checksum mismatch.
>
> If clang and/or gcc provide a .kcfi_traps section it will be possible to
> print proper CFI messages instead of just crashing the kernel (enable
> ARCH_USES_CFI_TRAPS).
> [ ... ]
> itself with two byte offset to execute an illegal instruction, and the
> following basr instruction used for an indirect branch.
>
> Reviewed-by: Jens Remus <jremus@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727140514.116501-1-hca@linux.ibm.com?part=6
prev parent reply other threads:[~2026-07-27 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:05 [PATCH v2 0/6] s390: Add kCFI support Heiko Carstens
2026-07-27 14:05 ` [PATCH v2 1/6] s390/tools: Pass symbol name to do_relocs() Heiko Carstens
2026-07-27 14:39 ` sashiko-bot
2026-07-27 14:05 ` [PATCH v2 2/6] s390/tools/relocs: Ignore __kcfi_typeid_ relocations Heiko Carstens
2026-07-27 14:36 ` sashiko-bot
2026-07-27 14:05 ` [PATCH v2 3/6] s390: Add ftrace_stub_graph Heiko Carstens
2026-07-27 14:40 ` sashiko-bot
2026-07-27 14:05 ` [PATCH v2 4/6] s390/diag: Generate CFI type information for assembly functions Heiko Carstens
2026-07-27 14:38 ` sashiko-bot
2026-07-27 14:05 ` [PATCH v2 5/6] s390/bpf: Add kCFI support Heiko Carstens
2026-07-27 14:47 ` sashiko-bot
2026-07-27 15:37 ` Ilya Leoshkevich
2026-07-27 14:05 ` [PATCH v2 6/6] s390/Kconfig: Select ARCH_SUPPORTS_CFI Heiko Carstens
2026-07-27 14:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727143913.452E51F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox