From: sashiko-bot@kernel.org
To: "K Prateek Nayak" <kprateek.nayak@amd.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v6 3/8] arm64/runtime-const: Introduce runtime_const_mask_32()
Date: Tue, 28 Jul 2026 05:36:56 +0000 [thread overview]
Message-ID: <20260728053656.A00441F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728052540.4728-4-kprateek.nayak@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly states the optimization is for 'amd64' instead of 'arm64' and misspells 'density'.
--
--- Patch [3]: [PATCH v6 3/8] arm64/runtime-const: Introduce runtime_const_mask_32() ---
commit 42eccec62a5249e8cefa9cbda5e62f01751903e8
Author: K Prateek Nayak <kprateek.nayak@amd.com>
arm64/runtime-const: Introduce runtime_const_mask_32()
This commit introduces runtime_const_mask_32() to optimize futex hash
computation mask operations on arm64. It utilizes a single UBFX instruction
for masks of the form GENMASK(n, 0) and implements runtime patching for the
width field.
Link: https://developer.arm.com/documentation/ddi0602/2026-03/Base-Instructions/ [1]
Link: https://lore.kernel.org/lkml/20260430094730.31624-4-kprateek.nayak@amd.com/ [2]
> instruction is used for amd64 to improve instruction dinsity and
> performance.
[Severity: Low]
This isn't a bug, but there are a couple of typos here: "amd64" instead of
"arm64", and "dinsity" instead of "density".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260728052540.4728-1-kprateek.nayak@amd.com?part=3
next prev parent reply other threads:[~2026-07-28 5:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 5:25 [PATCH v6 0/8] futex: Use runtime constants for futex_hash computation K Prateek Nayak
2026-07-28 5:25 ` [PATCH v6 1/8] x86/runtime-const: Introduce runtime_const_mask_32() K Prateek Nayak
2026-07-28 5:37 ` sashiko-bot
2026-07-28 8:21 ` K Prateek Nayak
2026-07-28 5:25 ` [PATCH v6 2/8] arm64/runtime-const: Use aarch64_insn_patch_text_nosync() for patching K Prateek Nayak
2026-07-28 5:35 ` sashiko-bot
2026-07-28 5:25 ` [PATCH v6 3/8] arm64/runtime-const: Introduce runtime_const_mask_32() K Prateek Nayak
2026-07-28 5:36 ` sashiko-bot [this message]
2026-07-28 5:25 ` [PATCH v6 4/8] riscv/runtime-const: Replace open-coded placeholder with RUNTIME_MAGIC K Prateek Nayak
2026-07-28 5:34 ` sashiko-bot
2026-07-28 5:25 ` [PATCH v6 5/8] riscv/runtime-const: Introduce runtime_const_mask_32() K Prateek Nayak
2026-07-28 5:38 ` sashiko-bot
2026-07-28 5:25 ` [PATCH v6 6/8] s390/runtime-const: " K Prateek Nayak
2026-07-28 5:36 ` sashiko-bot
2026-07-28 5:25 ` [PATCH v6 7/8] asm-generic/runtime-const: Add dummy runtime_const_mask_32() K Prateek Nayak
2026-07-28 5:34 ` sashiko-bot
2026-07-28 5:25 ` [PATCH v6 8/8] futex: Use runtime constants for __futex_hash() hot path K Prateek Nayak
2026-07-28 5:42 ` sashiko-bot
2026-07-28 10:46 ` Peter Zijlstra
2026-07-28 11:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728053656.A00441F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox