From: sashiko-bot@kernel.org
To: "Finn Callies" <fcallies@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 1/1] s390/ap: Fix MAPML computation
Date: Wed, 05 Aug 2026 09:45:16 +0000 [thread overview]
Message-ID: <20260805094517.860BF1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260805092928.26932-1-fcallies@linux.ibm.com>
> When the TAPQ subfunction of PQAP returns a value between 0 and 3 in the
> ml field, the Principles of Operation states that the Maximum AP Message
> Length (MAPML) must be 12 KB.
>
> The previous code incorrectly calculated smaller sizes for ml values 1-2:
> - ml=1: 4 KB instead of 12 KB
> - ml=2: 8 KB instead of 12 KB
>
> While no current hardware reports ml=1 or ml=2, this fix ensures correct
> behavior for specification compliance and future-proofing.
>
> The fix ensures all ml values 0-3 correctly use the 12 KB default, with
> only values 4+ using the formula ml * 4096.
>
> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
> Signed-off-by: Finn Callies <fcallies@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260805092928.26932-1-fcallies@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-08-05 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 9:29 [PATCH v2 1/1] s390/ap: Fix MAPML computation Finn Callies
2026-08-05 9:45 ` sashiko-bot [this message]
2026-08-05 9:57 ` Heiko Carstens
2026-08-05 13:01 ` Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805094517.860BF1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=fcallies@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox