From: sashiko-bot@kernel.org
To: "Christian Borntraeger" <borntraeger@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH on master] KVM: s390: Fix memory corruption by not reinjecting CK machine checks
Date: Thu, 06 Aug 2026 13:16:47 +0000 [thread overview]
Message-ID: <20260806131647.C74DE1F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260806130410.14254-1-borntraeger@linux.ibm.com>
> Channel-subsystem damage machine checks are for the host channel
> subsystem. The guest channel subsystem is emulated in the userspace VMM.
> There is no point in forwarding such machine checks into the guest.
>
> This also simplifies the machine check reinjection and avoids kfree of a
> stack variable as reported by sashiko. There might be still machine
> checks that have the ck bit set with another bit (like instruction
> damage), mask out the CK bit in s390_backup_mcck_info(), like the CP and
> ED bits already are.
>
> Fixes: 4d62fcc0b692 ("KVM: s390: Inject machine check into the guest")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260806130410.14254-1-borntraeger@linux.ibm.com?part=1
prev parent reply other threads:[~2026-08-06 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 12:52 [PATCH 0/1] address one of sashiko pre-existing issues Christian Borntraeger
2026-08-06 12:52 ` [PATCH 1/1] KVM: s390: Fix memory corruption by not reinjecting CK machine checks Christian Borntraeger
2026-08-06 14:20 ` Heiko Carstens
2026-08-06 14:37 ` Claudio Imbrenda
2026-08-06 14:39 ` Christian Borntraeger
2026-08-06 13:04 ` [PATCH on master] " Christian Borntraeger
2026-08-06 13:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806131647.C74DE1F00A3E@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox