From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH 1/2] scsi: zfcp: Add __must_hold() attribute to zfcp_qdio_sbal_get()
Date: Thu, 06 Aug 2026 13:59:37 +0000 [thread overview]
Message-ID: <20260806135938.8BC441F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260806134759.2122369-2-hca@linux.ibm.com>
> Add __must_hold() attribute to zfcp_qdio_sbal_get() in order to let
> clang's context analysis know that qdio->req_q_wq must be held on
> function entry. This is also documented above the function. Without this
> annotation this leads to a valid warning when context analysis is
> enabled:
>
> drivers/s390/scsi/zfcp_qdio.c:287:8: warning:
> expecting spinlock '->req_q_lock' to be held at start of each loop [-Wthread-safety-analysis]
> 287 | ret = wait_event_interruptible_lock_irq_timeout(qdio->req_q_wq,
> | ^
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260806134759.2122369-1-hca@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-08-06 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 13:47 [PATCH 0/2] scsi: zfcp: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-06 13:47 ` [PATCH 1/2] scsi: zfcp: Add __must_hold() attribute to zfcp_qdio_sbal_get() Heiko Carstens
2026-08-06 13:59 ` sashiko-bot [this message]
2026-08-06 13:47 ` [PATCH 2/2] scsi: zfcp: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-06 13:50 ` sashiko-bot
2026-08-06 16:36 ` [PATCH 0/2] " Bart Van Assche
2026-08-07 17:47 ` Martin K. Petersen (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806135938.8BC441F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox