From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Subject: [PATCH 1/2] s390/con3215: Add __must_hold() attribute to raw3215_make_room()
Date: Thu, 6 Aug 2026 17:53:02 +0200 [thread overview]
Message-ID: <20260806155303.2675932-2-hca@linux.ibm.com> (raw)
In-Reply-To: <20260806155303.2675932-1-hca@linux.ibm.com>
Add __must_hold() attribute to raw3215_make_room() in order to let
clang's context analysis know that "get_ccwdev_lock(raw->cdev)" must be
held on function entry. This can also be easily verified when inspecting
the function.
Without this annotation this leads to a valid warning when context
analysis is enabled:
drivers/s390/char/con3215.c:485:9: warning:
expecting spinlock 'raw->cdev->ccwlock' to be held at start of each loop [-Wthread-safety-analysis]
485 | while (RAW3215_BUFFER_SIZE - raw->count < length) {
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
drivers/s390/char/con3215.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 46265f4fbfd8..57fefa8986d6 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -481,6 +481,7 @@ static unsigned int raw3215_drop(struct raw3215_info *raw)
*/
static unsigned int raw3215_make_room(struct raw3215_info *raw,
unsigned int length, bool drop)
+ __must_hold(get_ccwdev_lock(raw->cdev))
{
while (RAW3215_BUFFER_SIZE - raw->count < length) {
if (drop)
--
2.53.0
next prev parent reply other threads:[~2026-08-06 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 15:53 [PATCH 0/2] s390/char: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-06 15:53 ` Heiko Carstens [this message]
2026-08-06 16:12 ` [PATCH 1/2] s390/con3215: Add __must_hold() attribute to raw3215_make_room() sashiko-bot
2026-08-07 9:23 ` Sven Schnelle
2026-08-06 15:53 ` [PATCH 2/2] s390/char: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-06 16:06 ` sashiko-bot
2026-08-07 9:23 ` Sven Schnelle
2026-08-07 10:49 ` [PATCH 0/2] " Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806155303.2675932-2-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).