Re: [PATCH 1/3] s390/vfio_ccw: Add __must_hold() attribute to vfio_ccw_sch_quiesce()

[Heiko Carstens <hca@linux.ibm.com>]

On Fri, Aug 07, 2026 at 12:55:28PM +0200, Christian Borntraeger wrote:
> 
> 
> Am 06.08.26 um 17:38 schrieb Heiko Carstens:
> > Add __must_hold() attribute to vfio_ccw_sch_quiesce() in order to let
> > clang's context analysis know that sch->lock must be held on function
> > entry. This can also be easily verified when inspecting the function.
> > 
> > Without this annotation this leads to a valid warning when context
> > analysis is enabled:
> > 
> > drivers/s390/cio/vfio_ccw_drv.c:55:9: warning:
> >    expecting spinlock 'sch->lock' to be held at start of each loop [-Wthread-safety-analysis]
> >     55 |                 ret = cio_cancel_halt_clear(sch, &iretry);
> >        |                       ^
> > 
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> 
> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> 
> I assume this series should go via the s390 tree with the others?

As written in the cover-letter:

"Christian, Claudio, Janosch, I think it would make most sense if this
 goes via kvms390."

:)