From: sashiko-bot@kernel.org
To: "Karl Mehltretter" <kmehltretter@gmail.com>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.vom>,
"Vasily Gorbik" <gor@linux.ibm.com>
Subject: Re: [PATCH] s390/percpu: Fix MVIY_PERCPU() with older binutils
Date: Wed, 12 Aug 2026 20:36:46 +0000 [thread overview]
Message-ID: <20260812203646.CCA3F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812203036.3018-1-kmehltretter@gmail.com>
> Commit a737737cdb9c ("s390/percpu: Infrastructure for more efficient
> this_cpu operations") introduced MVIY_PERCPU(), which stringifies
> arguments that are already C string literals. This generates an
> assembler macro invocation with whitespace-separated quoted arguments:
>
> GEN_MVIY "459712" "%r3"
>
> GNU as versions prior to binutils 2.39 drop the separating whitespace
> between quoted macro arguments during input scrubbing. They
> consequently parse the invocation as a single argument and emit
> repeated warnings:
>
> Warning: missing closing `"'
>
> The .ifc in GEN_MVIY never matches and GNU as exits successfully
> [ ... ]
> supports binutils 2.30.
>
> Fixes: a737737cdb9c ("s390/percpu: Infrastructure for more efficient this_cpu operations")
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812203036.3018-1-kmehltretter@gmail.com?part=1
prev parent reply other threads:[~2026-08-12 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 20:30 [PATCH] s390/percpu: Fix MVIY_PERCPU() with older binutils Karl Mehltretter
2026-08-12 20:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812203646.CCA3F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.vom \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kmehltretter@gmail.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox