From: sashiko-bot@kernel.org
To: "Christoph Hellwig" <hch@lst.de>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-raid@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
dsterba@suse.cz, yukuai@fygo.io,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.vom>
Subject: Re: [PATCH 05/28] xor: move to lib/raid/
Date: Thu, 13 Aug 2026 23:03:13 +0000 [thread overview]
Message-ID: <20260813230318.A87491F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260327061704.3707577-6-hch@lst.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The MAINTAINERS file was not updated to reflect the new location of the RAID XOR core code.
--
--- Patch [5]: [PATCH 05/28] xor: move to lib/raid/ ---
commit 521ed07e83a1bf1233d2291dd851539fa8fc5883
Author: Christoph Hellwig <hch@lst.de>
xor: move to lib/raid/
Move the RAID XOR code to lib/raid/ as it has nothing to do with the
crypto API.
[ ... ]
> diff --git a/crypto/xor.c b/lib/raid/xor/xor-core.c
> similarity index 100%
> rename from crypto/xor.c
> rename to lib/raid/xor/xor-core.c
[Severity: Low]
Should the MAINTAINERS file be updated to include the new directory?
Looking at the SOFTWARE RAID (Multiple Disks) SUPPORT section in MAINTAINERS,
it currently includes:
F: include/uapi/linux/raid/
F: lib/raid6/
The new lib/raid/xor/ directory is not covered by any maintainer entry. This
omission will cause scripts/get_maintainer.pl to fail to route future patches
touching these files to the appropriate subsystem maintainers.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260327061704.3707577-1-hch@lst.de?part=5
next prev parent reply other threads:[~2026-08-13 23:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 6:16 cleanup the RAID5 XOR library v4 Christoph Hellwig
2026-03-27 6:16 ` [PATCH 01/28] xor: assert that xor_blocks is not call from interrupt context Christoph Hellwig
2026-04-30 3:24 ` patchwork-bot+linux-riscv
2026-03-27 6:16 ` [PATCH 02/28] arm/xor: remove in_interrupt() handling Christoph Hellwig
2026-03-27 6:16 ` [PATCH 03/28] arm64/xor: fix conflicting attributes for xor_block_template Christoph Hellwig
2026-03-27 8:25 ` Ard Biesheuvel
2026-03-27 6:16 ` [PATCH 04/28] um/xor: cleanup xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 05/28] xor: move to lib/raid/ Christoph Hellwig
2026-08-13 23:03 ` sashiko-bot [this message]
2026-03-27 6:16 ` [PATCH 06/28] xor: small cleanups Christoph Hellwig
2026-03-27 6:16 ` [PATCH 07/28] xor: cleanup registration and probing Christoph Hellwig
2026-03-27 6:16 ` [PATCH 08/28] xor: split xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 09/28] xor: remove macro abuse for XOR implementation registrations Christoph Hellwig
2026-03-27 6:16 ` [PATCH 10/28] xor: move generic implementations out of asm-generic/xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 11/28] alpha: move the XOR code to lib/raid/ Christoph Hellwig
2026-03-27 6:16 ` [PATCH 12/28] arm: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 13/28] arm64: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 14/28] loongarch: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 15/28] powerpc: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 16/28] riscv: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 17/28] sparc: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 18/28] s390: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 19/28] x86: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 20/28] xor: avoid indirect calls for arm64-optimized ops Christoph Hellwig
2026-03-27 6:16 ` [PATCH 21/28] xor: make xor.ko self-contained in lib/raid/ Christoph Hellwig
2026-03-27 6:16 ` [PATCH 22/28] xor: add a better public API Christoph Hellwig
2026-04-10 3:03 ` Dan Williams
2026-03-27 6:16 ` [PATCH 23/28] " Christoph Hellwig
2026-03-27 17:51 ` Andrew Morton
2026-03-27 6:16 ` [PATCH 24/28] async_xor: use xor_gen Christoph Hellwig
2026-04-10 3:19 ` Dan Williams
2026-03-27 6:16 ` [PATCH 25/28] btrfs: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 26/28] xor: pass the entire operation to the low-level ops Christoph Hellwig
2026-03-27 6:16 ` [PATCH 27/28] xor: use static_call for xor_gen Christoph Hellwig
2026-03-27 6:17 ` [PATCH 28/28] xor: add a kunit test case Christoph Hellwig
2026-03-27 10:37 ` cleanup the RAID5 XOR library v4 Ard Biesheuvel
2026-03-27 17:49 ` Andrew Morton
2026-03-29 21:31 ` Eric Biggers
2026-03-29 22:51 ` Andrew Morton
2026-03-30 4:07 ` Eric Biggers
2026-03-30 5:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813230318.A87491F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.vom \
--cc=dsterba@suse.cz \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox