Re: [PATCH RFC v3 02/13] proc: add config option SYSCTL_MODULE_ALIASES

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit introduces a Kconfig option `SYSCTL_MODULE_ALIASES` but provides no implementation for the feature it claims to add.
--

--- Patch [2]: [PATCH RFC v3 02/13] proc: add config option SYSCTL_MODULE_ALIASES ---
commit 37ecdac6e4285c04cfa8fe2dd84f446aa5082a2f
Author: Mauricio Faria de Oliveira <mfo@igalia.com>

proc: add config option SYSCTL_MODULE_ALIASES

This commit adds a new Kconfig option for the 'sysctl:' module aliases
feature, allowing users to enable or disable it during kernel configuration.

> diff --git a/fs/proc/Kconfig b/fs/proc/Kconfig
> index 24f5a36f45df8..ea77cb2b0b0e3 100644
> --- a/fs/proc/Kconfig
> +++ b/fs/proc/Kconfig
> @@ -98,6 +98,19 @@ config SYSCTL
>  	  building a kernel for install/rescue disks or your system is very
>  	  limited in memory.
>  
> +config SYSCTL_MODULE_ALIASES
> +	bool "'sysctl:' module aliases (EXPERIMENTAL)"
> +	depends on SYSCTL && MODULES

[Severity: Medium]
Is the implementation for this feature missing from this patch?

The commit adds the SYSCTL_MODULE_ALIASES configuration option, but there
do not appear to be any references to CONFIG_SYSCTL_MODULE_ALIASES in any
C source files or Makefiles. Could this cause a situation where a user
enables the option expecting the functionality described in the help text,
but the feature remains completely unbacked by code?

> +	default n
> +	help
> +	  The /proc/sys files registered by a module do not exist until the

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819-sysctl-module-aliases-v3-0-aab90569365d@igalia.com?part=2