Re: [PATCH v6 14/21] KVM: s390: vsie: Add helper to pin and unpin multiple guest pages

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message claims to move the existing pin_guest_page() and unpin_guest_page() functions up in the file, but the patch diff does not include this move.
--

commit a11cc329acfe8885a8df6bb69ed2fa17d85d1e17
Author: Christoph Schlameuss <schlameuss@linux.ibm.com>

KVM: s390: vsie: Add helper to pin and unpin multiple guest pages

This commit introduces helpers to pin and unpin multiple consecutive guest-2
pages in guest-1 to handle vSIE configurations with an ssca. It iterates over
the pages and stores guest and host addresses for later use.

> Since the new methods use the existing {,un}pin_guest_page() helpers,
> they are moved up unchanged in the file to avoid having to resort to
> forward declarations later on.

[Severity: Low]
Is this portion of the commit message accurate for this specific patch?

It appears the relocation of the existing {,un}pin_guest_page() functions 
was already performed in an earlier patch in the series. The diff for 
this patch only introduces the new plural helpers without moving any 
existing code.

Could the commit message be updated to avoid confusion and reflect that 
the code movement was already handled?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-vsie-sigpi-v6-0-8020bb53be52@linux.ibm.com?part=14