From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>
Subject: Re: [PATCH AUTOSEL 6.18-5.10] s390/zcore: Removed unused variables
Date: Mon, 31 Aug 2026 15:29:05 +0000 [thread overview]
Message-ID: <20260831152906.11D021F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260831133314.4125787-294-sashal@kernel.org>
> From: Heiko Carstens <hca@linux.ibm.com>
>
> [ Upstream commit 0a2aa995c0a1d363b5f0803862e84834e3876ae2 ]
>
> allmodconfig with clang W=1 points out unused global variables:
>
> drivers/s390/char/zcore.c:49:23: error: variable
> 'zcore_reipl_file' set but not used [-Werror,-Wunused-but-set-global]
> drivers/s390/char/zcore.c:50:23: error: variable
> 'zcore_hsa_file' set but not used [-Werror,-Wunused-but-set-global]
>
> Remove both of them, since there is no point in keeping them.
>
> Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831133314.4125787-294-sashal@kernel.org?part=1
next prev parent reply other threads:[~2026-08-31 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260831133314.4125787-1-sashal@kernel.org>
2026-08-31 13:25 ` [PATCH AUTOSEL 6.18-5.10] s390/zcore: Removed unused variables Sasha Levin
2026-08-31 15:29 ` sashiko-bot [this message]
2026-08-31 13:29 ` [PATCH AUTOSEL 6.18-5.15] s390/cio: Purge based on the cdev's online status Sasha Levin
2026-08-31 17:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831152906.11D021F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox