From: Damien Le Moal <dlemoal@kernel.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Niklas Cassel <cassel@kernel.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>
Subject: [PATCH v3 00/40] Use defined 16-bits ASC/ASCQ combinations
Date: Fri, 4 Sep 2026 09:26:04 +0900 [thread overview]
Message-ID: <20260904002644.157668-1-dlemoal@kernel.org> (raw)
Martin, James,
This patch series defines as macros all ASC/ASCQ combinations present in
https://www.t10.org/lists/asc-num.txt and converts the SCSI core code and
SCSI low level drivers to use these macros instead of hard-coded
ASC/ASCQs. To do this, struct scsi_sense_hdr and struct scsi_failure are
modified to replace the asc and ascq 8-bits fields with a 16-bits
sense_code field.
This cleans up the code in many places and makes it easier, and self
documented, to test sense codes in the case of errors.
Overall, there should be no functional chnages here.
Note: this dwiseries currently applies cleanly to Linus tree, but will
have a conflict with a libata fix patch that will be sent out for 7.3rc2.
Changes from v2:
- Removed unintended duplication of KUNIT_EXPECT_EQ() call in patch 7
(Sashiko comment).
- Improved patch 38 to directly use 16-bits sense code instead of passing
only an ascq around (Sashiko comment).
- Added missing local variable initialization in
spc_emulate_request_sense() in patch 34 (Sashiko comment).
- Added review tags
Sashiko also did comment about several pre-existing issues for different
drivers, but I am not addressing these issues in this series.
Changes from v1:
- Addressed Sashiko comments signaling missing "ASC_" prefix when using
the named macros for ASC codes.
- Fixed up patch 7 to correct trace event print of asc/ascq. Also
extended the use of scsi_set_sense() in place of scsi_build_sense().
- Modified patch 37 to extend the use of scsi_set_sense_buffer() in place
of scsi_build_sense_buffer().
- Added patch 34 and 38 to extend the use of scsi_set_sense() in place of
scsi_build_sense().
- Added patch 40 to remove scsi_build_sense() and
scsi_build_sense_buffer().
Damien Le Moal (40):
scsi: define all additional sense codes and their qualifiers
scsi: constants: use defined sense codes
scsi: constants: rename internal struct field names
scsi: rename sense field of struct scsi_failure
scsi: prepare for using 16-bits defined sense codes
scsi: use struct scsi_sense_hdr to log sense keys and codes
scsi: core: use 16-bits defined sense codes
scsi: sd: use 16-bits defined sense codes
scsi: sr: use 16-bits defined sense codes
scsi: ses: use 16-bits defined sense codes
scsi: ch: use 16-bits defined sense codes
scsi: st: use 16-bits defined sense codes
scsi: device_handlers: hp_sw: use 16-bits defined sense codes
scsi: device_handlers: rdac: use 16-bits defined sense codes
scsi: device_handlers: emc: use 16-bits defined sense codes
scsi: device_handlers: alua: use 16-bits defined sense codes
scsi: mpt3sas: use 16-bits defined sense codes
scsi: mpi3mr: use 16-bits defined sense codes
scsi: 3w-xxxx: use 16-bits defined sense codes
scsi: leapraid: use 16-bits defined sense codes
scsi: megaraid: use 16-bits defined sense codes
scsi: myrX: use 16-bits defined sense codes
scsi: smartpqi: use 16-bits defined sense codes
scsi: qla2xxx: use 16-bits defined sense codes
scsi: ps3rom: use 16-bits defined sense codes
scsi: lpfc: use 16-bits defined sense codes
scsi: stex: use 16-bits defined sense codes
scsi: mvumi: use 16-bits defined sense codes
scsi: libiscsi: use 16-bits defined sense codes
scsi: ibmvscsi_tgt: use 16-bits defined sense codes
scsi: scsi_debug: use 16-bits defined sense codes
scsi: hpsa: use 16-bits defined sense codes
scsi: storvsc: use 16-bits defined sense codes
target: use 16-bits defined sense codes
usb: storage: use 16-bits defined sense codes
cdrom: use 16-bits defined sense codes
ata: libata: use 16-bits defined sense codes
s390: scsi: use 16-bits defined sense codes
scsi: cleanup scsi_proto.h
scsi: remove scsi_build_sense() and scsi_build_sense_buffer()
drivers/ata/libata-eh.c | 13 +-
drivers/ata/libata-sata.c | 20 +-
drivers/ata/libata-scsi.c | 346 ++-
drivers/ata/libata.h | 5 +-
drivers/cdrom/cdrom.c | 10 +-
drivers/s390/scsi/zfcp_ext.h | 2 +-
drivers/s390/scsi/zfcp_fsf.c | 9 +-
drivers/s390/scsi/zfcp_scsi.c | 6 +-
drivers/scsi/3w-xxxx.c | 3 +-
drivers/scsi/ch.c | 55 +-
drivers/scsi/constants.c | 61 +-
drivers/scsi/device_handler/scsi_dh_alua.c | 55 +-
drivers/scsi/device_handler/scsi_dh_emc.c | 28 +-
drivers/scsi/device_handler/scsi_dh_hp_sw.c | 29 +-
drivers/scsi/device_handler/scsi_dh_rdac.c | 55 +-
drivers/scsi/hpsa.c | 69 +-
drivers/scsi/hpsa_cmd.h | 23 -
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 +-
drivers/scsi/leapraid/leapraid_func.h | 7 -
drivers/scsi/leapraid/leapraid_os.c | 15 +-
drivers/scsi/libiscsi.c | 3 +-
drivers/scsi/lpfc/lpfc_scsi.c | 18 +-
drivers/scsi/megaraid.c | 8 +-
drivers/scsi/megaraid/mega_common.h | 2 -
drivers/scsi/megaraid/megaraid_mbox.c | 12 +-
drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +-
drivers/scsi/mpi3mr/mpi3mr_os.c | 50 +-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 69 +-
drivers/scsi/mvumi.c | 2 +-
drivers/scsi/myrb.c | 67 +-
drivers/scsi/myrs.c | 23 +-
drivers/scsi/ps3rom.c | 5 +-
drivers/scsi/qla2xxx/qla_isr.c | 9 +-
drivers/scsi/scsi.c | 3 +-
drivers/scsi/scsi_common.c | 24 +-
drivers/scsi/scsi_debug.c | 332 +--
drivers/scsi/scsi_error.c | 94 +-
drivers/scsi/scsi_ioctl.c | 3 +-
drivers/scsi/scsi_lib.c | 133 +-
drivers/scsi/scsi_lib_test.c | 95 +-
drivers/scsi/scsi_logging.c | 22 +-
drivers/scsi/scsi_scan.c | 22 +-
drivers/scsi/scsi_transport_spi.c | 12 +-
drivers/scsi/sd.c | 126 +-
drivers/scsi/sd_zbc.c | 2 +-
drivers/scsi/sense_codes.h | 2496 ++++++++++++------
drivers/scsi/ses.c | 23 +-
drivers/scsi/smartpqi/smartpqi_init.c | 31 +-
drivers/scsi/sr.c | 3 +-
drivers/scsi/sr_ioctl.c | 29 +-
drivers/scsi/st.c | 35 +-
drivers/scsi/stex.c | 3 +-
drivers/scsi/storvsc_drv.c | 15 +-
drivers/target/target_core_spc.c | 11 +-
drivers/target/target_core_transport.c | 11 +-
drivers/target/target_core_ua.c | 28 +-
drivers/target/target_core_ua.h | 7 +-
drivers/usb/gadget/function/f_mass_storage.c | 34 +-
drivers/usb/gadget/function/storage_common.h | 71 +-
drivers/usb/storage/debug.c | 12 +-
drivers/usb/storage/debug.h | 4 +-
drivers/usb/storage/transport.c | 7 +-
include/scsi/scsi_cmnd.h | 3 +-
include/scsi/scsi_common.h | 16 +-
include/scsi/scsi_dbg.h | 6 +-
include/scsi/scsi_device.h | 26 +-
include/scsi/scsi_proto.h | 71 +-
include/scsi/scsi_sense.h | 943 +++++++
include/trace/events/scsi.h | 4 +-
69 files changed, 3829 insertions(+), 2015 deletions(-)
create mode 100644 include/scsi/scsi_sense.h
--
2.55.0
next reply other threads:[~2026-09-04 0:26 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 0:26 Damien Le Moal [this message]
2026-09-04 0:26 ` [PATCH v3 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-04 0:38 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-04 0:36 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-04 0:38 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-04 0:43 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-04 0:45 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-04 0:48 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-04 0:53 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 08/40] scsi: sd: " Damien Le Moal
2026-09-04 1:04 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 09/40] scsi: sr: " Damien Le Moal
2026-09-04 1:02 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 10/40] scsi: ses: " Damien Le Moal
2026-09-04 1:06 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 11/40] scsi: ch: " Damien Le Moal
2026-09-04 1:09 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 12/40] scsi: st: " Damien Le Moal
2026-09-04 1:11 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-04 1:13 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-04 1:15 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-04 1:20 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-04 1:27 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-04 1:26 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-04 1:32 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 19/40] scsi: 3w-xxxx: " Damien Le Moal
2026-09-04 1:33 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 20/40] scsi: leapraid: " Damien Le Moal
2026-09-04 1:39 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 21/40] scsi: megaraid: " Damien Le Moal
2026-09-04 1:42 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 22/40] scsi: myrX: " Damien Le Moal
2026-09-04 1:53 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-04 1:48 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-04 1:52 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 25/40] scsi: ps3rom: " Damien Le Moal
2026-09-04 2:00 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 26/40] scsi: lpfc: " Damien Le Moal
2026-09-04 2:00 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 27/40] scsi: stex: " Damien Le Moal
2026-09-04 2:08 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 28/40] scsi: mvumi: " Damien Le Moal
2026-09-04 2:12 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-04 2:12 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-04 2:20 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-04 2:23 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 32/40] scsi: hpsa: " Damien Le Moal
2026-09-04 2:27 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 33/40] scsi: storvsc: " Damien Le Moal
2026-09-04 2:41 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 34/40] target: " Damien Le Moal
2026-09-04 2:37 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 35/40] usb: storage: " Damien Le Moal
2026-09-04 2:43 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 36/40] cdrom: " Damien Le Moal
2026-09-04 2:46 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 37/40] ata: libata: " Damien Le Moal
2026-09-04 2:49 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 38/40] s390: scsi: " Damien Le Moal
2026-09-04 2:50 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-04 2:56 ` sashiko-bot
2026-09-04 0:26 ` [PATCH v3 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-04 2:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904002644.157668-1-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox