From: sashiko-bot@kernel.org
To: "Damien Le Moal" <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
dlemoal@kernel.org, cassel@kernel.org,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v5 04/40] scsi: rename sense field of struct scsi_failure
Date: Mon, 07 Sep 2026 02:54:15 +0000 [thread overview]
Message-ID: <20260907025416.4167C1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907024343.1046387-5-dlemoal@kernel.org>
> Rename the sense field of struct scsi_failure to sense_key. This makes
> it clear that this field stores the sense key, and also unifies this
> structure field names with the names used in struct scsi_sense_hdr.
>
> To be consistent with this change, the macro SCMD_FAILURE_SENSE_ANY is
> renamed SCMD_FAILURE_SENSE_KEY_ANY.
>
> Of note is that the definition of the array any_sense_failure_defs in
> scsi_lib_test_any_sense() is modified to change the initialization of the
> result field to use SCMD_FAILURE_RESULT_ANY and add the .sense_key field
> initialization to SCMD_FAILURE_SENSE_KEY_ANY to match the test target
> case.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907024343.1046387-1-dlemoal@kernel.org?part=4
next prev parent reply other threads:[~2026-09-07 2:54 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 2:43 [PATCH v5 00/40] Use defined 16-bits ASC/ASCQ combinations Damien Le Moal
2026-09-07 2:43 ` [PATCH v5 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-07 3:14 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-07 2:51 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-07 2:48 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-07 2:54 ` sashiko-bot [this message]
2026-09-07 2:43 ` [PATCH v5 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-07 2:54 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-07 2:52 ` sashiko-bot
2026-09-07 20:05 ` Bart Van Assche
2026-09-08 0:32 ` Damien Le Moal
2026-09-07 2:43 ` [PATCH v5 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-07 2:54 ` sashiko-bot
2026-09-07 20:03 ` Bart Van Assche
2026-09-08 0:32 ` Damien Le Moal
2026-09-07 2:43 ` [PATCH v5 08/40] scsi: sd: " Damien Le Moal
2026-09-07 3:11 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 09/40] scsi: sr: " Damien Le Moal
2026-09-07 2:54 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 10/40] scsi: ses: " Damien Le Moal
2026-09-07 2:56 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 11/40] scsi: ch: " Damien Le Moal
2026-09-07 2:54 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 12/40] scsi: st: " Damien Le Moal
2026-09-07 2:57 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-07 2:50 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-07 2:52 ` sashiko-bot
2026-09-07 14:11 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-07 3:02 ` sashiko-bot
2026-09-07 14:13 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-07 2:57 ` sashiko-bot
2026-09-07 14:21 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-07 2:55 ` sashiko-bot
2026-09-07 14:28 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-07 2:55 ` sashiko-bot
2026-09-07 14:30 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 19/40] scsi: 3w-xxxx: " Damien Le Moal
2026-09-07 2:58 ` sashiko-bot
2026-09-07 14:39 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 20/40] scsi: leapraid: " Damien Le Moal
2026-09-07 3:00 ` sashiko-bot
2026-09-07 14:48 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 21/40] scsi: megaraid: " Damien Le Moal
2026-09-07 2:56 ` sashiko-bot
2026-09-07 14:50 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 22/40] scsi: myrX: " Damien Le Moal
2026-09-07 2:59 ` sashiko-bot
2026-09-07 14:54 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-07 2:57 ` sashiko-bot
2026-09-07 14:57 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-07 2:58 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 25/40] scsi: ps3rom: " Damien Le Moal
2026-09-07 3:03 ` sashiko-bot
2026-09-07 15:25 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 26/40] scsi: lpfc: " Damien Le Moal
2026-09-07 3:02 ` sashiko-bot
2026-09-07 15:26 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 27/40] scsi: stex: " Damien Le Moal
2026-09-07 3:04 ` sashiko-bot
2026-09-07 15:26 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 28/40] scsi: mvumi: " Damien Le Moal
2026-09-07 3:03 ` sashiko-bot
2026-09-07 15:29 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-07 3:03 ` sashiko-bot
2026-09-07 15:29 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-07 3:05 ` sashiko-bot
2026-09-07 15:32 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-07 3:12 ` sashiko-bot
2026-09-07 15:41 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 32/40] scsi: hpsa: " Damien Le Moal
2026-09-07 3:03 ` sashiko-bot
2026-09-07 15:57 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 33/40] scsi: storvsc: " Damien Le Moal
2026-09-07 3:06 ` sashiko-bot
2026-09-07 15:59 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 34/40] target: " Damien Le Moal
2026-09-07 3:11 ` sashiko-bot
2026-09-07 2:43 ` [PATCH v5 35/40] usb: storage: " Damien Le Moal
2026-09-07 3:02 ` sashiko-bot
2026-09-07 16:13 ` Johannes Thumshirn
2026-09-08 0:27 ` Damien Le Moal
2026-09-08 1:20 ` Alan Stern
2026-09-07 2:43 ` [PATCH v5 36/40] cdrom: " Damien Le Moal
2026-09-07 3:03 ` sashiko-bot
2026-09-07 16:21 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 37/40] ata: libata: " Damien Le Moal
2026-09-07 3:04 ` sashiko-bot
2026-09-07 16:21 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 38/40] s390: scsi: " Damien Le Moal
2026-09-07 3:09 ` sashiko-bot
2026-09-07 16:25 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-07 3:07 ` sashiko-bot
2026-09-07 16:45 ` Johannes Thumshirn
2026-09-07 2:43 ` [PATCH v5 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-07 3:02 ` sashiko-bot
2026-09-07 16:57 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907025416.4167C1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox