From: sashiko-bot@kernel.org
To: "Jan Polensky" <japo@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2] s390/rwlock: Add contention tracepoints to rwlock slowpath
Date: Tue, 08 Sep 2026 14:07:37 +0000 [thread overview]
Message-ID: <20260908140748.1382B1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908135843.1384367-1-japo@linux.ibm.com>
> Instrument arch_read_lock_wait() and arch_write_lock_wait() with
> trace_contention_begin() and trace_contention_end().
>
> These tracepoints are used by lock contention analysis tools such as
> perf lock contention to identify contended rwlocks and measure wait
> times. The generic implementation in kernel/locking/qrwlock.c already
> emits the same events from its read and write slowpaths.
>
> For arch_read_lock_wait(), the in_interrupt() fast-path is intentionally
> left outside the tracepoint scope. That path spins without entering the
> wait queue, so it does not represent queue-based contention and its
> duration is not comparable to the normal slowpath. This matches the
> behaviour of queued_read_lock_slowpath() in qrwlock.c.
>
> The include for <trace/events/lock.h> is already present from
> commit ffa796cc1f45 ("s390/spinlock: Add contention tracepoints to
> lock slowpath").
>
> Signed-off-by: Jan Polensky <japo@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908135843.1384367-1-japo@linux.ibm.com?part=1
prev parent reply other threads:[~2026-09-08 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:58 [PATCH v2] s390/rwlock: Add contention tracepoints to rwlock slowpath Jan Polensky
2026-09-08 14:07 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908140748.1382B1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=japo@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox