From: Simon Horman <horms@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Alexandra Winter <wintera@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH net-next] net/iucv: Add lock nesting annotation in iucv_sock_close()
Date: Sun, 13 Sep 2026 14:42:09 +0100 [thread overview]
Message-ID: <20260913134209.GH48209@horms.kernel.org> (raw)
In-Reply-To: <20260911162945.B92321F000FF@smtp.kernel.org>
On Fri, Sep 11, 2026 at 04:29:45PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>
> Pre-existing issues:
> - [Critical] Lockless traversal of accept_q causes list corruption and use-after-free due to concurrent modifications from softirq context.
> - [High] Newly allocated sockets are permanently leaked on error paths because iucv_sock_kill() returns early if SOCK_ZAPPED is not set.
> - [High] Child socket leak in iucv_sock_cleanup_listen due to late state update leaving a race window.
> - [High] Unprotected state modifications in iucv_callback_connack cause state desynchronization.
My opinion is that the issues above are all orthogonal to this patch
and should not block progress of it.
...
next prev parent reply other threads:[~2026-09-13 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 16:29 [PATCH net-next] net/iucv: Add lock nesting annotation in iucv_sock_close() Alexandra Winter
2026-09-11 16:29 ` sashiko-bot
2026-09-13 13:42 ` Simon Horman [this message]
2026-09-13 16:12 ` Alexandra Winter
2026-09-13 13:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913134209.GH48209@horms.kernel.org \
--to=horms@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox