From: sashiko-bot@kernel.org
To: "Pengpeng Hou" <hppiscas@163.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH net v3] net/iucv: require IUCV for AF_IUCV sockets
Date: Sun, 20 Sep 2026 03:50:13 +0000 [thread overview]
Message-ID: <20260920035014.645681F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260920034503.17322-1-hppiscas@163.com>
> AFIUCV can currently be selected with IUCV disabled. That configuration
> does not build af_iucv.o because the parent Makefile only enters
> net/iucv under CONFIG_IUCV. Independently entering the directory is not
> sufficient: AF_IUCV also relies on the IUCV implementation.
>
> Restore the IUCV dependency for AFIUCV, as proposed during review. This
> also constrains AFIUCV to a module when its IUCV provider is modular,
> without changing the directory traversal rules.
>
> The issue was found by our static-analysis tool.
>
> Fixes: c69748d1c9b5 ("iucv: kernel option for z/VM IUCV and HiperSockets")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920034503.17322-1-hppiscas@163.com?part=1
next prev parent reply other threads:[~2026-09-20 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 3:45 [PATCH net v3] net/iucv: require IUCV for AF_IUCV sockets Pengpeng Hou
2026-09-20 3:50 ` sashiko-bot [this message]
2026-09-21 3:48 ` netdev-bot+sashiko
2026-09-24 18:52 ` Alexandra Winter
2026-09-25 15:16 ` Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920035014.645681F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hppiscas@163.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox