From: Vineeth Vijayan <vneethv@linux.ibm.com>
To: oberpar@linux.ibm.com
Cc: hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
linux-s390@vger.kernel.org
Subject: [PATCH] s390/cio: Fix NULL dereference in ccw_device_get_util_str()
Date: Tue, 22 Sep 2026 22:48:39 +0200 [thread overview]
Message-ID: <20260922204839.965043-1-vneethv@linux.ibm.com> (raw)
The channel path registry entry associated with a CHPID may be removed
while the subchannel's PMCW still references that CHPID. In this case,
chpid_to_chp() can return NULL, leading to a NULL pointer dereference.
Add the missing NULL check before dereferencing the returned pointer.
Fixes: 199652309a4d ("s390/cio: add helper to query utility strings per given ccw device")
Cc: stable@vger.kernel.org
Signed-off-by: Vineeth Vijayan <vneethv@linux.ibm.com>
---
drivers/s390/cio/device_ops.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/s390/cio/device_ops.c b/drivers/s390/cio/device_ops.c
index f2f7f8cba410..1f7e83fd5087 100644
--- a/drivers/s390/cio/device_ops.c
+++ b/drivers/s390/cio/device_ops.c
@@ -517,6 +517,8 @@ u8 *ccw_device_get_util_str(struct ccw_device *cdev, int chp_idx)
chp_id_init(&chpid);
chpid.id = sch->schib.pmcw.chpid[chp_idx];
chp = chpid_to_chp(chpid);
+ if (!chp)
+ return NULL;
util_str = kmalloc(sizeof(chp->desc_fmt3.util_str), GFP_KERNEL);
if (!util_str)
--
2.53.0
next reply other threads:[~2026-09-22 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 20:48 Vineeth Vijayan [this message]
2026-09-22 21:01 ` [PATCH] s390/cio: Fix NULL dereference in ccw_device_get_util_str() sashiko-bot
2026-09-23 8:57 ` Peter Oberparleiter
2026-09-23 9:22 ` Vineeth Vijayan
2026-09-23 14:38 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922204839.965043-1-vneethv@linux.ibm.com \
--to=vneethv@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox