Re: [PATCH v6 1/8] dma: swiotlb: Rename swiotlb_size_or_default()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: missed function rename to swiotlb_default_pool_size()
--

commit 88c990f98bc8ebb1b961e1f014a4e9bab02d6131
Author: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>

dma: swiotlb: Rename swiotlb_size_or_default()

This commit renames swiotlb_size_or_default() to swiotlb_default_pool_size()
to clarify that it returns the current size of the default pool. This includes
sizes resulting from command-line modifications or heuristics, not just the
compiled-in default.

> diff --git a/arch/x86/include/asm/crash_reserve.h b/arch/x86/include/asm/crash_reserve.h
> index 7835b2cdff04a..047f638a766d7 100644
> --- a/arch/x86/include/asm/crash_reserve.h
> +++ b/arch/x86/include/asm/crash_reserve.h
[ ... ]
> @@ -33,7 +33,7 @@ extern unsigned long swiotlb_size_or_default(void);
>  static inline unsigned long crash_low_size_default(void)
>  {
>  #ifdef CONFIG_X86_64
> -	return max(swiotlb_size_or_default() + (8UL << 20), 256UL << 20);
> +	return max(swiotlb_default_pool_size() + (8UL << 20), 256UL << 20);

[Severity: Low]
Since the function swiotlb_size_or_default() is renamed to
swiotlb_default_pool_size() here in crash_low_size_default(), does the
corresponding documentation in Documentation/admin-guide/kernel-parameters.txt
also need to be updated?

The documentation string currently still uses the old function name to explain
the crashkernel reservation formula on x86:

Documentation/admin-guide/kernel-parameters.txt:
        --> x86: max(swiotlb_size_or_default() + 8MiB, 256MiB)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924060756.1325156-1-aneesh.kumar@kernel.org?part=1