Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH 4/4] um: ORC unwinder support
Date: Thu, 24 Sep 2026 12:52:06 +0000	[thread overview]
Message-ID: <20260924125206.80D9A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924144039.52fff8ac4e16.Ie3f2b9610f0bc9cf45ca82c17f3b9e0f90354ea4@changeid>

> From: Johannes Berg <johannes.berg@intel.com>
> 
> Add support for the ORC unwinder on 64-bit UML. Since that's just
> normal x86_64 code, the objtool etc. is the same and the unwinder
> itself is mostly copied from x86, except
>  - register accesses, obviously;
>  - no need for (entry) assembly support
>  - interrupts are host signals, so we can unwind across them
>    by detecting the signal restorer and using the ucontext
> 
> Note that due to the indirect calls with -mcmodel=large objtool
> gets confused in some places resulting in some warnings, but I
> couldn't find a way to suppress that and it seemed harmless.
> 
> Assisted-by: LLM
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924124039.1621965-6-johannes@sipsolutions.net?part=4


      reply	other threads:[~2026-09-24 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 12:35 [PATCH 0/4] ORC unwinder cleanup & UML support Johannes Berg
2026-09-24 12:35 ` [PATCH 1/4] s390: remove unwind_module_init() Johannes Berg
2026-09-24 12:43   ` sashiko-bot
2026-09-24 12:48   ` Heiko Carstens
2026-09-24 12:35 ` [PATCH 2/4] ORC: pull out module handling from x86/loongarch Johannes Berg
2026-09-24 12:49   ` sashiko-bot
2026-09-24 12:35 ` [PATCH 3/4] ORC: unify orc_hash.h generation Johannes Berg
2026-09-24 12:48   ` sashiko-bot
2026-09-24 12:35 ` [PATCH 4/4] um: ORC unwinder support Johannes Berg
2026-09-24 12:52   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924125206.80D9A1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox