Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: linux-s390@vger.kernel.org,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v5 10/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sparc32
Date: Fri, 25 Sep 2026 20:29:53 +0000	[thread overview]
Message-ID: <20260925202953.EB5B71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925-rcu-pagetable-freeing-v5-10-31e91065fea4@kernel.org>

> Careful handling is required for sparc32 which implements page tables as
> part of a shared backing page.
> 
> To support this, a custom __tlb_remove_table() function is required, as
> specified by CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE.
> 
> This allows __pte_free_tlb() and __pmd_free_tlb() to specify which page
> table level is being freed, which is transmitted to __tlb_remove_table()
> through setting the lowest bit of the page table to 1 for a PMD and 0 for a
> PTE (the page tables are 256-byte aligned so this is safe to do).
> 
> Next, since the page table freeing is done via RCU callback, and thus might
> be executed in softirq context, update the spin locks to IRQ save/restore.
> 
> Then, in __tlb_remove_table(), figure out whether to free a PMD page table
> [ ... ]
> 
> Acked-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> Tested-by: Lance Yang <lance.yang@linux.dev>
> Acked-by: Lance Yang <lance.yang@linux.dev>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-rcu-pagetable-freeing-v5-0-31e91065fea4@kernel.org?part=10


  reply	other threads:[~2026-09-25 20:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 20:09 [PATCH v5 00/12] mm: make userland page table freeing RCU-safe Lorenzo Stoakes (ARM)
2026-09-25 20:09 ` [PATCH v5 01/12] mm/khugepaged: deposit a newly allocated page table on collapse Lorenzo Stoakes (ARM)
2026-09-25 20:25   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 02/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for most 2-level architectures Lorenzo Stoakes (ARM)
2026-09-25 20:24   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 03/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for MMU riscv Lorenzo Stoakes (ARM)
2026-09-25 20:19   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 04/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for MMU arm Lorenzo Stoakes (ARM)
2026-09-25 20:23   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 05/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for arc, microblaze, xtensa Lorenzo Stoakes (ARM)
2026-09-25 20:24   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 06/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sparc64 Lorenzo Stoakes (ARM)
2026-09-25 20:22   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 07/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for m68k-coldfire Lorenzo Stoakes (ARM)
2026-09-25 20:21   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 08/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sh-X2 Lorenzo Stoakes (ARM)
2026-09-25 20:25   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 09/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for m68k-motorola Lorenzo Stoakes (ARM)
2026-09-25 20:28   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 10/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sparc32 Lorenzo Stoakes (ARM)
2026-09-25 20:29   ` sashiko-bot [this message]
2026-09-25 20:09 ` [PATCH v5 11/12] mm: userland pgtable freeing is RCU-safe now, remove leftover bits Lorenzo Stoakes (ARM)
2026-09-25 20:33   ` sashiko-bot
2026-09-25 20:09 ` [PATCH v5 12/12] mm: change the contract for free_pgtables(), update docs Lorenzo Stoakes (ARM)
2026-09-25 20:28   ` sashiko-bot
2026-09-28 12:06   ` David Hildenbrand (Arm)
2026-09-25 22:28 ` [PATCH v5 00/12] mm: make userland page table freeing RCU-safe Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925202953.EB5B71F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox