From: sashiko-bot@kernel.org
To: "Chengfeng Ye" <nicoyip.dev@gmail.com>
Cc: linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/smc: Hold a socket reference for transmit work
Date: Sun, 27 Sep 2026 08:02:03 +0000 [thread overview]
Message-ID: <20260927080204.70FBE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927075120.3695060-1-nicoyip.dev@gmail.com>
> SMC transmit work is queued without holding a socket reference. After
> an active close has cancelled tx_work, a received CDC message can queue
> it again while the socket is in SMC_PEERCLOSEWAIT1. Passive close can
> then reach SMC_CLOSED, call smc_conn_free() and drop the last socket
> reference before smc_tx_work() acquires the socket lock. The worker
> then accesses the freed socket.
>
> KASAN reported:
>
> BUG: KASAN: slab-use-after-free in lock_sock_nested+0x97/0x180
> Write of size 8 by task kworker/0:1/11
> Workqueue: smc_tx_wq-00000000 smc_tx_work
> Call Trace:
> lock_sock_nested+0x97/0x180
> smc_tx_work+0x5d/0x170
> [ ... ]
>
> Fixes: e6727f39004b ("smc: send data (through RDMA)")
> Cc: stable@vger.kernel.org
> Link: https://lists.openwall.net/netdev/2026/09/09/105
> Signed-off-by: Chengfeng Ye <nicoyip.dev@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927075120.3695060-1-nicoyip.dev@gmail.com?part=1
next prev parent reply other threads:[~2026-09-27 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 7:51 [PATCH net] net/smc: Hold a socket reference for transmit work Chengfeng Ye
2026-09-27 8:02 ` sashiko-bot [this message]
2026-10-01 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927080204.70FBE1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nicoyip.dev@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox