From: sashiko-bot@kernel.org
To: "Artem Dinaburg" <artem@trailofbits.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH 6.6.y] kvm: s390: Reject memory region operations for ucontrol VMs
Date: Wed, 30 Sep 2026 01:22:12 +0000 [thread overview]
Message-ID: <20260930012213.2E23B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930011211.94657-1-artem@trailofbits.com>
> From: Christoph Schlameuss <schlameuss@linux.ibm.com>
>
> [ Upstream commit 7816e58967d0e6cadce05c8540b47ed027dc2499 ]
>
> This change rejects the KVM_SET_USER_MEMORY_REGION and
> KVM_SET_USER_MEMORY_REGION2 ioctls when called on a ucontrol VM.
> This is necessary since ucontrol VMs have kvm->arch.gmap set to 0 and
> would thus result in a null pointer dereference further in.
> Memory management needs to be performed in userspace and using the
> ioctls KVM_S390_UCAS_MAP and KVM_S390_UCAS_UNMAP.
>
> Also improve s390 specific documentation for KVM_SET_USER_MEMORY_REGION
> and KVM_SET_USER_MEMORY_REGION2.
>
> [ Backport to 6.6.y: omitted KVM_SET_USER_MEMORY_REGION2 documentation
> because that ioctl is absent from 6.6.y. ]
>
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> Fixes: 27e0393f15fc ("KVM: s390: ucontrol: per vcpu address spaces")
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Link: https://lore.kernel.org/r/20240624095902.29375-1-schlameuss@linux.ibm.com
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> [frankja@linux.ibm.com: commit message spelling fix, subject prefix fix]
> Message-ID: <20240624095902.29375-1-schlameuss@linux.ibm.com>
> Assisted-by: LLM
> Signed-off-by: Artem Dinaburg <artem@trailofbits.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930011211.94657-1-artem@trailofbits.com?part=1
next prev parent reply other threads:[~2026-09-30 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 1:12 [PATCH 6.6.y] kvm: s390: Reject memory region operations for ucontrol VMs Artem Dinaburg
2026-09-30 1:22 ` sashiko-bot [this message]
2026-10-01 13:52 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930012213.2E23B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=artem@trailofbits.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox