From: Jakub Kicinski <kuba@kernel.org>
To: Atharva Vartak <atharva.a.vartak@gmail.com>
Cc: security@kernel.org, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, mjambigi@linux.ibm.com,
sidraya@linux.ibm.com, w@1wt.eu, tonylu@linux.alibaba.com,
guwen@linux.alibaba.com, linux-rdma@vger.kernel.org,
linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net/smc: hold a reference on net_device returned by pnet_find_base_ndev()
Date: Thu, 1 Oct 2026 17:13:45 -0700 [thread overview]
Message-ID: <20261001171345.1d9d0a2b@kernel.org> (raw)
In-Reply-To: <6aba080c.b933486d.297b72.5042@mx.google.com>
On Sun, 27 Sep 2026 23:24:12 -0700 (PDT) Atharva Vartak wrote:
> @@ -949,6 +952,8 @@ static struct net_device *pnet_find_base_ndev(struct net_device *ndev)
> {
> rtnl_lock();
> ndev = __pnet_find_base_ndev(ndev);
> + /* keep ndev alive after dropping RTNL, callers must dev_put() */
> + dev_hold(ndev);
> rtnl_unlock();
> return ndev;
dev_hold() is deprecated, please use netdev_hold() with a correctly
populated ref tracker.
--
pw-bot: cr
prev parent reply other threads:[~2026-10-02 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <arn3qTu_SeM8Yrjj@1wt.eu>
2026-09-28 6:24 ` [PATCH] net/smc: hold a reference on net_device returned by pnet_find_base_ndev() Atharva Vartak
2026-09-28 6:31 ` netdev-bot+sinfo
2026-09-28 6:37 ` sashiko-bot
2026-10-02 0:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001171345.1d9d0a2b@kernel.org \
--to=kuba@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=atharva.a.vartak@gmail.com \
--cc=dust.li@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox