Re: [RFC PATCH v3 05/13] MIPS: Initialize sbm topology on multi-node systems

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mips: modpost section mismatch from cpu_node_probe() calling __init function
--

commit a182a04b59c7d5076dc4fa89322bc392b7a56f93
Author: K Prateek Nayak <kprateek.nayak@amd.com>

MIPS: Initialize sbm topology on multi-node systems

For MIPS systems that support NUMA, configure the sparsebitmap (sbm)
topology.

> diff --git a/arch/mips/kernel/topology.c b/arch/mips/kernel/topology.c
> index 9429d85a4703c..bb6d14bfe5ebb 100644
> --- a/arch/mips/kernel/topology.c
> +++ b/arch/mips/kernel/topology.c
> [ ... ]
> @@ -5,9 +5,52 @@
>  #include <linux/node.h>
>  #include <linux/nodemask.h>
>  #include <linux/percpu.h>
> +#include <linux/sbm.h>
>  
>  static DEFINE_PER_CPU(struct cpu, cpu_devices);
>  
> +#ifdef CONFIG_NUMA
> +/* sbm setup data - only needed during init */
> +static struct cpumask cpu_sbm_setup_map __initdata;
> +static int __node_thread_count[NR_CPUS] __initdata;
> +
> +int arch_sbm_cpu_instance_id(int cpu)
> +{
> +	return cpu_to_node(cpu);
> +}
> +
> +void __init configure_sbm_topology(void)
> +{
> [ ... ]
> diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c
> index 62733e049570a..244f8d987f13b 100644
> --- a/arch/mips/sgi-ip27/ip27-smp.c
> +++ b/arch/mips/sgi-ip27/ip27-smp.c
> [ ... ]
> @@ -80,6 +81,8 @@ void cpu_node_probe(void)
>  		highest = node_scan_cpus(nasid, highest);
>  	}
>  
> +	configure_sbm_topology();

[Severity: Low]
Does this cause a modpost section mismatch warning?

Since configure_sbm_topology() is marked __init in
arch/mips/kernel/topology.c, calling it from cpu_node_probe() creates a
cross-section reference because cpu_node_probe() is not marked __init.

While cpu_node_probe() might only be called during initialization,
shouldn't it also be marked __init to prevent the .text section from
referencing the freed .init.text section?

> +
>  	printk("Discovered %d cpus on %d nodes\n", highest + 1, num_online_nodes());
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001192849.74788-1-kprateek.nayak@amd.com?part=5