Re: [PATCH] s390/dis: Mark non-NUL-terminated character arrays with __nonstring

[sashiko-bot@kernel.org]

> With [1] the generated string initializers were changed to use an
> array instead of a non-NUL-terminated string. The reason was that GCC 15
> warns about string initializers that truncate the NUL terminator with
> -Wunterminated-string-initialization.
> 
> The better solution is to use the __nonstring annotation, which exists
> to deal exactly with this problem. Therefore use it and basically
> revert [1] in order to generate more readable initializers:
> 
> Before:
> [LONG_INSN_ALGHSIK] = { 'a', 'l', 'g', 'h', 's', 'i', 'k', },
> 
> After:
> [LONG_INSN_ALGHSIK] = "alghsik",
> 
> [1] commit 7cbae7ea3de5 ("s390/tools: Use array instead of string initializer")
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002104446.2077269-1-hca@linux.ibm.com?part=1